1752912 - Assertion failure: mPathVertices.IsEmpty() (have vertices but no path), at /dom/svg/SVGMotionSMILAnimationFunction.cpp:306

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jason Kratzer [:jkratzer]]

Testcase found while fuzzing mozilla-central rev bb528a123b65 (built with: --enable-debug --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build bb528a123b65 --debug --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html

Assertion failure: mPathVertices.IsEmpty() (have vertices but no path), at /dom/svg/SVGMotionSMILAnimationFunction.cpp:306

    ==1719219==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7f84d2008764 bp 0x7ffd4c3f7fd0 sp 0x7ffd4c3f7fc0 T1719219)
    ==1719219==The signal is caused by a WRITE memory access.
    ==1719219==Hint: address points to the zero page.
        #0 0x7f84d2008764 in mozilla::SVGMotionSMILAnimationFunction::GetValues(mozilla::SMILAttr const&, FallibleTArray<mozilla::SMILValue>&) /dom/svg/SVGMotionSMILAnimationFunction.cpp:306:5
        #1 0x7f84d23a8eb3 in mozilla::SMILAnimationFunction::ComposeResult(mozilla::SMILAttr const&, mozilla::SMILValue&) /dom/smil/SMILAnimationFunction.cpp:192:17
        #2 0x7f84d23a78d9 in mozilla::SMILCompositor::ComposeAttribute(bool&) /dom/smil/SMILCompositor.cpp:97:29
        #3 0x7f84d23a6333 in mozilla::SMILAnimationController::DoSample(bool) /dom/smil/SMILAnimationController.cpp:413:17
        #4 0x7f84d2a8a896 in Resample /builds/worker/workspace/obj-build/dist/include/mozilla/SMILAnimationController.h:73:21
        #5 0x7f84d2a8a896 in FlushResampleRequests /builds/worker/workspace/obj-build/dist/include/mozilla/SMILAnimationController.h:86:5
        #6 0x7f84d2a8a896 in mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) /layout/base/PresShell.cpp:4238:46
        #7 0x7f84d2a514c0 in nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsRefreshDriver::IsExtraTick) /layout/base/nsRefreshDriver.cpp:2393:22
        #8 0x7f84d2a59b20 in TickDriver /layout/base/nsRefreshDriver.cpp:348:13
        #9 0x7f84d2a59b20 in mozilla::RefreshDriverTimer::TickRefreshDrivers(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver> >&) /layout/base/nsRefreshDriver.cpp:326:7
        #10 0x7f84d2a59a23 in mozilla::RefreshDriverTimer::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) /layout/base/nsRefreshDriver.cpp:342:5
        #11 0x7f84d2a598f0 in mozilla::VsyncRefreshDriverTimer::RunRefreshDrivers(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) /layout/base/nsRefreshDriver.cpp:780:5
        #12 0x7f84d2a5911a in mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) /layout/base/nsRefreshDriver.cpp:703:16
        #13 0x7f84d2a58973 in mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyParentProcessVsync() /layout/base/nsRefreshDriver.cpp:620:7
        #14 0x7f84d2a58549 in mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyVsync(mozilla::VsyncEvent const&) /layout/base/nsRefreshDriver.cpp:541:9
        #15 0x7f84d21fb80a in mozilla::dom::VsyncMainChild::RecvNotify(mozilla::VsyncEvent const&, float const&) /dom/ipc/VsyncMainChild.cpp:68:15
        #16 0x7f84ceb4bce5 in mozilla::dom::PVsyncChild::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PVsyncChild.cpp:208:54
        #17 0x7f84ce8e7fec in mozilla::ipc::PBackgroundChild::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PBackgroundChild.cpp:6167:32
        #18 0x7f84ce561081 in mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) /ipc/glue/MessageChannel.cpp:1658:25
        #19 0x7f84ce55e4c2 in mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) /ipc/glue/MessageChannel.cpp:1583:9
        #20 0x7f84ce55f00d in mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) /ipc/glue/MessageChannel.cpp:1452:3
        #21 0x7f84ce55faed in mozilla::ipc::MessageChannel::MessageTask::Run() /ipc/glue/MessageChannel.cpp:1480:14
        #22 0x7f84cdad058e in mozilla::RunnableTask::Run() /xpcom/threads/TaskController.cpp:467:16
        #23 0x7f84cdaaa416 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:770:26
        #24 0x7f84cdaa90d8 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:606:15
        #25 0x7f84cdaa9353 in mozilla::TaskController::ProcessPendingMTTask(bool) /xpcom/threads/TaskController.cpp:390:36
        #26 0x7f84cdad35c6 in operator() /xpcom/threads/TaskController.cpp:124:37
        #27 0x7f84cdad35c6 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:531:5
        #28 0x7f84cdabece3 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1195:16
        #29 0x7f84cdac5dca in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:467:10
        #30 0x7f84ce566396 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:85:21
        #31 0x7f84ce48b0f7 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:331:10
        #32 0x7f84ce48b002 in RunHandler /ipc/chromium/src/base/message_loop.cc:324:3
        #33 0x7f84ce48b002 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:306:3
        #34 0x7f84d27573d8 in nsBaseAppShell::Run() /widget/nsBaseAppShell.cpp:137:27
        #35 0x7f84d47b7033 in XRE_RunAppShell() /toolkit/xre/nsEmbedFunctions.cpp:870:20
        #36 0x7f84ce56728a in mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:235:9
        #37 0x7f84ce48b0f7 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:331:10
        #38 0x7f84ce48b002 in RunHandler /ipc/chromium/src/base/message_loop.cc:324:3
        #39 0x7f84ce48b002 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:306:3
        #40 0x7f84d47b666c in XRE_InitChildProcess(int, char**, XREChildData const*) /toolkit/xre/nsEmbedFunctions.cpp:707:34
        #41 0x563a39ba0029 in content_process_main /browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
        #42 0x563a39ba0029 in main /browser/app/nsBrowserApp.cpp:327:18
        #43 0x7f84e3f050b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16
        #44 0x563a39b7b7bc in _start (/home/jkratzer/builds/mc-debug/firefox-bin+0x157bc)
    
    UndefinedBehaviorSanitizer can not provide additional info.
    SUMMARY: UndefinedBehaviorSanitizer: SEGV /dom/svg/SVGMotionSMILAnimationFunction.cpp:306:5 in mozilla::SVGMotionSMILAnimationFunction::GetValues(mozilla::SMILAttr const&, FallibleTArray<mozilla::SMILValue>&)
    ==1719219==ABORTING

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Testcase

Comment 2

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Verified bug as reproducible on mozilla-central 20220131212843-788ab1920ef8.
Failed to bisect testcase (Testcase reproduces on start build!):

Start: babdc3b3a30001ae014cc9180992549c5e4d5045 (20210202033500)
End: bb528a123b65479d96326b5f4d5b7981538542d2 (20220131165143)
BuildFlags: BuildFlags(asan=False, tsan=False, debug=True, fuzzing=True, coverage=False, valgrind=False, no_opt=False, fuzzilli=False)

Comment 3

[Daniel Holbert [:dholbert]]

Likely harmless; --> S3.

ni=myself to take a look soon (this is an assertion I added in 2010 in bug 436418).

Comment 4

[Bugmon [:jkratzer for issues]]

Bugmon was unable reproduce this issue.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 5

[Jason Kratzer [:jkratzer]]

A change to the Taskcluster build definitions over the weekend caused Bugmon to fail when reproducing issues. This issue has been corrected. Re-enabling bugmon.

Comment 6

[Bugmon [:jkratzer for issues]]

Testcase crashes using the initial build (mozilla-central 20220716092056-c682cdddfbf1) but not with tip (mozilla-central 20230714094120-196cda3a1052.)

The bug appears to have been fixed in the following build range:

Start: 1bfb25414a090700f286cd06319e91cb9ac6e336 (20230713114710)
End: b1d2fc1363420fa8da0efcfaa87cc63d88085004 (20230713131622)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1bfb25414a090700f286cd06319e91cb9ac6e336&tochange=b1d2fc1363420fa8da0efcfaa87cc63d88085004

jkratzer, can you confirm that the above bisection range is responsible for fixing this issue?
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 7

[Robert Longson [:longsonr]]

Fixed by bug 825254