1753025 - Using the correct principal to create channel for ServiceWorker NavigationPreload.

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P1)

Comment 1

[Eden Chuang[:edenchuang]]

Attachment: Bug 1753025 - Using correct principal to create channel for NavigationPreload. r=#dom-worker-reviewers

Currently using the pricinpal of InternalRequest to create the channel for NavigationPreload.
However, it is not a correct principal and makes NavigationPreload stop with channel security checking.
Instead of using the principal of InternalRequest, this patch uses the loadingPrincipal of InterceptedHttpChannel to create the channel.

Comment 2

[Eden Chuang[:edenchuang]]

Attachment: Bug 1753025 - Adding debugging log for FetchSerivce/FetchInstance. r=#dom-worker-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90e9e803f010
Using correct principal to create channel for NavigationPreload. r=dom-worker-reviewers,jesup
https://hg.mozilla.org/integration/autoland/rev/09f9724c8c1c
Adding debugging log for FetchSerivce/FetchInstance. r=dom-worker-reviewers,jesup

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing build bustages on Logging.h

Backout link : https://hg.mozilla.org/integration/autoland/rev/7dbedaab687b42d8a6ba8813ae486a744af0835b

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-base-toolchains%2Fdebug%2Cbb&revision=c07607b89a61eba9596da0bfb618f9387dc7abdf&selectedTaskRun=YTG2QRapRP6CH6EJCJRYmQ.0

Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=367078071&repo=autoland&lineNumber=9374

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/ff0c5f5b0a60
Backed out 3 changesets (bug 1753025, bug 1750515) for causing build bustages on Logging.h a=backout

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99bacb6a3d92
Using correct principal to create channel for NavigationPreload. r=dom-worker-reviewers,jesup
https://hg.mozilla.org/integration/autoland/rev/f671d5206b88
Adding debugging log for FetchSerivce/FetchInstance. r=dom-worker-reviewers,jesup

Comment 7

[Marian-Vasile Laza]

Backed out 3 changesets (Bug 1750515, Bug 1753025) for causing wpt failures on idlharness.https.any.<...>.
Backout link
Push with failures
Failure Log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7692c70b812d
Using correct principal to create channel for NavigationPreload. r=dom-worker-reviewers,jesup
https://hg.mozilla.org/integration/autoland/rev/fb5026c2f822
Adding debugging log for FetchSerivce/FetchInstance. r=dom-worker-reviewers,jesup

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7692c70b812d
https://hg.mozilla.org/mozilla-central/rev/fb5026c2f822

Comment 10

[Eden Chuang[:edenchuang]]

Comment on attachment 9261807 [details]
Bug 1753025 - Using correct principal to create channel for NavigationPreload. r=#dom-worker-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: If the user turns on NavigationPreload, it could make NavigationPreload fail due to using the wrong principal to create a channel.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Currently, NavigationPreload should be turned on manually. NavigationPreload fails would not cause ServiceWorker interception to fail, but it cannot gain the performance by NavigationPreload.
• String changes made/needed: No

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Eden, could you explain how this is impacting our 98 release? I see this is blocking a feature that landed in 99 and is nightly only. Thanks

Comment 12

[Eden Chuang[:edenchuang]]

Pascal, thanks for ni. Yes, after discussion, we decide to make the feature be on with 98 release in default.
To make this feature be turned on, we need to uplift patches of this bug, and also bug 1750515 and bug 1754786. This is because we changed the test expectation result in these patches.
Patches in this bug have no dependency on other bugs for uplifting, so this is the first one to uplift. Then the patches on bug 1750515 and bug 1754786.

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9261807 [details]
Bug 1753025 - Using correct principal to create channel for NavigationPreload. r=#dom-worker-reviewers

The feature is now targeting 99