1753034 - telemetry-tests-client should not create nonlocal connections to Search Engine pages

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Julian Descottes [:jdescottes]]

See Bug 1371576.

Various telemetry-tests-client exercise the search feature from the URL bar: https://searchfox.org/mozilla-central/rev/e3a7a72713e1ba8696cb2af55e928059bc822572/toolkit/components/telemetry/tests/marionette/harness/telemetry_harness/testcase.py#75

This leads to load the results page of the selected search engine during the test.
Since those tests are tier1, they should not perform any network connection (see Bug 1371576 comment #39).

We should either find a way of running those without hitting the network (and ideally force MOZ_DISABLE_NONLOCAL_CONNECTIONS to avoid regressions) or set them as tier 2.

Note that those tests currently fail even earlier on try for a glean ping. See Bug 1753003

Comment 1

[Chris H-C :chutten]

test_event_ping.py can be removed since coverage is present in xpcshell
test_search_counts_across_sessions.py can be removed because fixing it would require more investment than the decreasing importance of Firefox Telemetry (in the face of Glean) warrants
test_fog_deletion_request_ping.py can just load about:glean instead of searching.

Comment 2

[Benjamin Forehand Jr[:b4hand]]

Attachment: Bug 1753034 - removed tests, and edited search test to use about:glean; r?chutten,jdescottes

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:b4hand, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 4

[Chris H-C :chutten]

Last I heard, b4hand was working on resubmitting a patch since the first one didn't apply

Comment 5

[Benjamin Forehand Jr[:b4hand]]

Attachment: Bug 1753034 - removed tests, and edited search test to use about:glean; r?jdescottes

Comment 6

[Benjamin Forehand Jr[:b4hand]]

Submitted another patch as the other one I tried to rebase on central and messed it all up.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4c2053e7320
removed tests, and edited search test to use about:glean; r=jdescottes

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e4c2053e7320