1753105 - Assertion failure: aMax >= aMin (clamped(): aMax must be greater than or equal to aMin), at /builds/worker/workspace/obj-build/dist/include/nsAlgorithm.h:37

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Jason Kratzer [:jkratzer]]

Testcase found while fuzzing mozilla-central rev 6a46314d2667 (built with: --enable-debug --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build 6a46314d2667 --debug --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html

Assertion failure: aMax >= aMin (clamped(): aMax must be greater than or equal to aMin), at /builds/worker/workspace/obj-build/dist/include/nsAlgorithm.h:37

    ==2299392==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7f4051639a34 bp 0x7ffeaeafda70 sp 0x7ffeaeafd860 T2299392)
    ==2299392==The signal is caused by a WRITE memory access.
    ==2299392==Hint: address points to the zero page.
        #0 0x7f4051639a34 in mozilla::SVGTextFrame::TransformFramePointToTextChild(mozilla::gfx::PointTyped<mozilla::gfx::UnknownUnits, float> const&, nsIFrame const*) /layout/svg/SVGTextFrame.cpp
        #1 0x7f405138552e in TransformGfxPointFromAncestor(mozilla::RelativeTo, mozilla::gfx::PointTyped<mozilla::gfx::UnknownUnits, float> const&, mozilla::RelativeTo, mozilla::Maybe<mozilla::gfx::Matrix4x4TypedFlagged<mozilla::gfx::UnknownUnits, mozilla::gfx::UnknownUnits> >&, mozilla::gfx::PointTyped<mozilla::gfx::UnknownUnits, float>*) /layout/base/nsLayoutUtils.cpp:2260:19
        #2 0x7f40513851b9 in nsLayoutUtils::TransformPoints(mozilla::RelativeTo, mozilla::RelativeTo, unsigned int, mozilla::gfx::PointTyped<mozilla::CSSPixel, float>*) /layout/base/nsLayoutUtils.cpp:2364:10
        #3 0x7f40512d7a19 in mozilla::TransformPoints(nsINode*, mozilla::dom::TextOrElementOrDocument const&, unsigned int, mozilla::gfx::PointTyped<mozilla::CSSPixel, float>*, mozilla::dom::ConvertCoordinateOptions const&, mozilla::dom::CallerType, mozilla::ErrorResult&) /layout/base/GeometryUtils.cpp:425:39
        #4 0x7f40512d7b86 in mozilla::ConvertRectFromNode(nsINode*, mozilla::dom::DOMRectReadOnly&, mozilla::dom::TextOrElementOrDocument const&, mozilla::dom::ConvertCoordinateOptions const&, mozilla::dom::CallerType, mozilla::ErrorResult&) /layout/base/GeometryUtils.cpp:469:3
        #5 0x7f404e3d14e3 in nsINode::ConvertRectFromNode(mozilla::dom::DOMRectReadOnly&, mozilla::dom::TextOrElementOrDocument const&, mozilla::dom::ConvertCoordinateOptions const&, mozilla::dom::CallerType, mozilla::ErrorResult&) /dom/base/nsINode.cpp:1328:10
        #6 0x7f404ee753d5 in mozilla::dom::Text_Binding::convertRectFromNode(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) /builds/worker/workspace/obj-build/dom/bindings/TextBinding.cpp:490:74
        #7 0x7f404f6d8828 in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) /dom/bindings/BindingUtils.cpp:3306:13
        #8 0x7f405319be7f in CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) /js/src/vm/Interpreter.cpp:425:13
        #9 0x7f405319b57d in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:512:12
        #10 0x7f405319d05e in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) /js/src/vm/Interpreter.cpp:572:10
        #11 0x7f4053192916 in CallFromStack /js/src/vm/Interpreter.cpp:576:10
        #12 0x7f4053192916 in Interpret(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:3309:16
        #13 0x7f4053189813 in js::RunScript(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:394:13
        #14 0x7f405319b478 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:544:13
        #15 0x7f405319d05e in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) /js/src/vm/Interpreter.cpp:572:10
        #16 0x7f405319d261 in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /js/src/vm/Interpreter.cpp:589:8
        #17 0x7f405335b841 in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /js/src/vm/CallAndConstruct.cpp:117:10
        #18 0x7f404f3f9587 in mozilla::dom::EventListener::HandleEvent(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::dom::Event&, mozilla::ErrorResult&) /builds/worker/workspace/obj-build/dom/bindings/EventListenerBinding.cpp:62:8
        #19 0x7f404fbabe96 in void mozilla::dom::EventListener::HandleEvent<mozilla::dom::EventTarget*>(mozilla::dom::EventTarget* const&, mozilla::dom::Event&, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*) /builds/worker/workspace/obj-build/dist/include/mozilla/dom/EventListenerBinding.h:65:12
        #20 0x7f404fbabc1a in mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*) /dom/events/EventListenerManager.cpp:1308:43
        #21 0x7f404fbac919 in mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool) /dom/events/EventListenerManager.cpp:1505:17
        #22 0x7f404fba1914 in HandleEvent /dom/events/EventListenerManager.h:395:5
        #23 0x7f404fba1914 in mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) /dom/events/EventDispatcher.cpp:348:17
        #24 0x7f404fba0e37 in mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) /dom/events/EventDispatcher.cpp:550:16
        #25 0x7f404fba3698 in mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) /dom/events/EventDispatcher.cpp:1085:11
        #26 0x7f404fba5f66 in mozilla::EventDispatcher::DispatchDOMEvent(nsISupports*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsPresContext*, nsEventStatus*) /dom/events/EventDispatcher.cpp
        #27 0x7f404e3d164d in nsINode::DispatchEvent(mozilla::dom::Event&, mozilla::dom::CallerType, mozilla::ErrorResult&) /dom/base/nsINode.cpp:1355:17
        #28 0x7f404df1ffaa in nsContentUtils::DispatchEvent(mozilla::dom::Document*, nsISupports*, nsTSubstring<char16_t> const&, mozilla::CanBubble, mozilla::Cancelable, mozilla::Composed, mozilla::Trusted, bool*, mozilla::ChromeOnlyDispatch) /dom/base/nsContentUtils.cpp:4323:28
        #29 0x7f404df1fda7 in nsContentUtils::DispatchTrustedEvent(mozilla::dom::Document*, nsISupports*, nsTSubstring<char16_t> const&, mozilla::CanBubble, mozilla::Cancelable, mozilla::Composed, bool*) /dom/base/nsContentUtils.cpp:4293:10
        #30 0x7f404e150b1f in mozilla::dom::Document::DispatchContentLoadedEvents() /dom/base/Document.cpp:7891:3
        #31 0x7f404e2024db in applyImpl<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1147:12
        #32 0x7f404e2024db in apply<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1153:12
        #33 0x7f404e2024db in mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1200:13
        #34 0x7f404c2fdd52 in mozilla::SchedulerGroup::Runnable::Run() /xpcom/threads/SchedulerGroup.cpp:140:20
        #35 0x7f404c32e05e in mozilla::RunnableTask::Run() /xpcom/threads/TaskController.cpp:467:16
        #36 0x7f404c307ee6 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:770:26
        #37 0x7f404c306ba8 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:606:15
        #38 0x7f404c306e23 in mozilla::TaskController::ProcessPendingMTTask(bool) /xpcom/threads/TaskController.cpp:390:36
        #39 0x7f404c331096 in operator() /xpcom/threads/TaskController.cpp:124:37
        #40 0x7f404c331096 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:531:5
        #41 0x7f404c31c7b3 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1195:16
        #42 0x7f404c32389a in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:467:10
        #43 0x7f404cdc3e86 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:85:21
        #44 0x7f404cce8be7 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:331:10
        #45 0x7f404cce8af2 in RunHandler /ipc/chromium/src/base/message_loop.cc:324:3
        #46 0x7f404cce8af2 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:306:3
        #47 0x7f4050fbdfb8 in nsBaseAppShell::Run() /widget/nsBaseAppShell.cpp:137:27
        #48 0x7f405301fb53 in XRE_RunAppShell() /toolkit/xre/nsEmbedFunctions.cpp:878:20
        #49 0x7f404cdc4d7a in mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:235:9
        #50 0x7f404cce8be7 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:331:10
        #51 0x7f404cce8af2 in RunHandler /ipc/chromium/src/base/message_loop.cc:324:3
        #52 0x7f404cce8af2 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:306:3
        #53 0x7f405301f18c in XRE_InitChildProcess(int, char**, XREChildData const*) /toolkit/xre/nsEmbedFunctions.cpp:715:34
        #54 0x565241f43029 in content_process_main /browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
        #55 0x565241f43029 in main /browser/app/nsBrowserApp.cpp:327:18
        #56 0x7f40611480b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16
        #57 0x565241f1e7bc in _start (/home/jkratzer/builds/mc-debug/firefox-bin+0x157bc)
    
    UndefinedBehaviorSanitizer can not provide additional info.
    SUMMARY: UndefinedBehaviorSanitizer: SEGV /layout/svg/SVGTextFrame.cpp in mozilla::SVGTextFrame::TransformFramePointToTextChild(mozilla::gfx::PointTyped<mozilla::gfx::UnknownUnits, float> const&, nsIFrame const*)
    ==2299392==ABORTING

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Testcase

Comment 2

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Verified bug as reproducible on mozilla-central 20220201213236-281df200fb3b.
The bug appears to have been introduced in the following build range:

Start: cef9ae46c12502db5397009a26ee7c303dd5d8a3 (20220128165222)
End: 68f4953185a3165f6114c3e2c9af9fcf7c009c33 (20220128171420)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cef9ae46c12502db5397009a26ee7c303dd5d8a3&tochange=68f4953185a3165f6114c3e2c9af9fcf7c009c33

Comment 3

[Daniel Holbert [:dholbert]]

In that regression range, this probably would have started reproducing due to this commit (from a few days ago):

https://hg.mozilla.org/integration/autoland/rev/14297312b35956973527a5e12d2a9b2d854f489f
Emilio Cobos Álvarez — Bug 1746794 - Make more nsLayoutUtils functions SVG-text aware. r=layout-reviewers,jfkthame

...given that nsLayoutUtils::TransformPoints and SVG text functions show up in the assertion-failure backtrace here.

(nsLayoutUtils::TransformPoints seems to have been modified a good bit in that^ commit).

emilio, maybe you could take a look? (Tentatively assuming this is S3 since the assertion-failure is just in some geometric computations & doesn't look catastrophic, but it'd be good to see what's going on here.)

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1746794

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1753105 - Deal with negative letter-spacing in SVGTextFrame. r=jfkthame

Otherwise we can end up with a rect with negative width, bad stuff to
follow.

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32701 for changes under testing/web-platform/tests

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d123c8a6e94c

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Verified bug as fixed on rev mozilla-central 20220205091402-e240dde296a8.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.