1753173 - [GTK] Failed to handle composition start signal which is sent immediately after setting IME focus

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

On Linux, IME may start composition immediately after getting focus and keep it until blur. In this case, IMContextWrapper fails to handle starting composition because ContentCacheInParent returns error for any query.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1753173 - part 1: Improve logging code of `IMEContentObserver` r=m_kato!

While I'm debugging bug 1735227, I found this bug. And for the debugging,
current IMEContentObserver's logging was not enough. Therefore, I wrote
this patch first.

Note that IMEContentObserver:: is not necessary in the log because it's
log module name is IMEContentObserver, therefore, it appears twice in
each line under current log format. Therefore, this patch removes it.

Additionally, I moved "position change" notification handling to "verbose"
because it's really noisy in web apps which update its content automatically
like SNS. So, IMEContentObserver:4,sync is useful in most cases, but can
see the detail with IMEContentObserver:5,sync.

Depends on D137522

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1753173 - part 2: Make `IMContextWrapper` set IME focus at receiving `NOTIFY_IME_OF_FOCUS` r=m_kato!

Currently, it sets "input-purpose" and "input-hints" and notify IME of focus
at updating InputContext. This occurs before receiving NOTIFY_IME_OF_FOCUS.
Therefore, at the moment, IMContextWrapper cannot access content cache, but
IME may query it. E.g., IME may start composition immediately
(ibus-pinyin 1.5.0-6 does it).

For avoiding the trouble, IMContextWrapper should notify IME of focus when
and only when it receives NOTIFY_IME_OF_FOCUS.

Depends on D137609

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6a334638505
part 1: Improve logging code of `IMEContentObserver` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/1ecdb0291382
part 2: Make `IMContextWrapper` set IME focus at receiving `NOTIFY_IME_OF_FOCUS` r=m_kato

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e6a334638505
https://hg.mozilla.org/mozilla-central/rev/1ecdb0291382