1753259 - Interacting with HG fails after upgrading from MozillaBuild 3.4 to 4.0

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Mitchell Hentges [:mhentges] 🦀]

This is because the path to hg is stored during configure, but the path changes with the new MozillaBuild release because we're now using hg with Python 3, not Python 2. So, %MOZILLABUILD%\python\Scripts\hg => %MOZILLABUILD%\python3\Scripts\hg.

The solution here is likely to attempt to use the "stored" hg path, but re-attempt to find a new hg if the stored path is incorrect.

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1753259: Try finding VCS tool if build config is outdated

Though not a panacea, this patch addresses existing usages of
get_repository_from_build_config() to fall back to
get_repository_object() if MissingVCSTool was encountered.

Ideally, we'd update substs["HG"] when we detect that it's changed,
but we don't have infrastructure to incrementally change configure
output.

So, other issues may creep up that will warrant a fresh
./mach configure.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d725eef2bc3
Try finding VCS tool if build config is outdated r=ahal

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/7d725eef2bc3