1753272 - Enable profiler stackwalking in Mac builds which don't have --enable-profiling

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Markus Stange [:mstange]]

On macOS, the profiler requires frame pointers in order to get C++ stacks. One way to force frame pointers is to use --enable-profiling, which is currently set for Nightly builds (by way of --enable-instruments), and which sets the MOZ_PROFILING define. But we can also have frame pointers in other ways, for example bug 1753107 just enabled them on all channels for macOS arm64 builds even if --enable-profiling is not set. And system libraries always have frame pointers.
So we should just enable stackwalking on macOS always. This will make the profiler's "stackwalk" feature available even in Firefox x86_64 Release builds, which currently don't have frame pointers. There it will only give us stacks for system libraries and not for XUL, but that's better than nothing.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1753272 - On macOS, always enable frame pointer stack walking, even in builds which may not have frame pointers. r=gerald

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b62a8e4b721
On macOS, always enable frame pointer stack walking, even in builds which may not have frame pointers. r=gerald

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/6b62a8e4b721