1753280 - [wpt-sync] Sync PR 32665 - Notify the flow thread about descendant removal in time.

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32665 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32665
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Notify the flow thread about descendant removal in time.

With LayoutNGBlockInInline enabled, it's possible to have a spanner
block inside an inline. The flow thread keeps track of all the spanners,
and the column rows between them, by inserting anonymous spanner
placeholder and column set objects. When modifying the tree, the flow
thread may need to add or remove spanner placeholders, and merge and
split column sets. When removing elements from the tree, it was possible
for such two spanners to swap order (because two anonymous blocks were
merged into one), without the flow thread noticing, and the spanner
placeholder / column set structure wasn't updated. And we'd crash.

Therefore, update the flow thread a bit earlier, before
LayoutBlockFlow::RemoveChild() gets to have too much fun with the tree
structure.

Bug: 1292004
Change-Id: Ic4d76d2851fbc1bd9d2dbacc9f350dc21f24a11c
Reviewed-on: https://chromium-review.googlesource.com/3432406
WPT-Export-Revision: c6cae0ea4ed689e37d122caf148d619357c0969e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2afa18743d4c02a7ec882c1a644b8013d6fca8b1

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e52bf68399f
[wpt PR 32665] - Notify the flow thread about descendant removal in time., a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3227f4df726c
[wpt PR 32665] - Notify the flow thread about descendant removal in time., a=testonly

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3227f4df726c