1753308 - make AddonTestUtils notify startup events for extensions

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Shane Caraveo (:mixedpuppy)]

Our tests have largely relied on bypassing startup logic that relies on notifications from non-toolkit code in Firefox. This makes testing delayed startup scenarios obtuse.

This patch removes the extensions.webextensions.background-delayed-startup preference in favor of a flag used by xpcshell tests that do not use the addon manager via AddonTestUtils. ATU now notifies the startup notifications which causes those tests to use the startup that would be used in the real world. New options for promiseStartupManager allow controlling this for tests that specifically need to test some early startup behavior (e.g. event pages, persistent listeners).

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1753308 fix extension startup in tests, remove delayed startup pref

Comment 2

[Shane Caraveo (:mixedpuppy)]

FYI, you should be aware of this change for Thunderbird as well.

Comment 3

[John Bieling (:TbSync)]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3886e3f90f9
fix extension startup in tests, remove delayed startup pref r=rpl,robwu

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e3886e3f90f9