Closed
Bug 1753308
Opened 2 years ago
Closed 2 years ago
make AddonTestUtils notify startup events for extensions
Categories
(WebExtensions :: General, enhancement, P1)
WebExtensions
General
Tracking
(firefox99 fixed)
RESOLVED
FIXED
99 Branch
Tracking | Status | |
---|---|---|
firefox99 | --- | fixed |
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
Details
(Whiteboard: [addons-jira])
Attachments
(1 file)
Our tests have largely relied on bypassing startup logic that relies on notifications from non-toolkit code in Firefox. This makes testing delayed startup scenarios obtuse.
This patch removes the extensions.webextensions.background-delayed-startup preference in favor of a flag used by xpcshell tests that do not use the addon manager via AddonTestUtils. ATU now notifies the startup notifications which causes those tests to use the startup that would be used in the real world. New options for promiseStartupManager allow controlling this for tests that specifically need to test some early startup behavior (e.g. event pages, persistent listeners).
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
FYI, you should be aware of this change for Thunderbird as well.
Flags: needinfo?(john)
Updated•2 years ago
|
Attachment #9261995 -
Attachment description: Bug 1753308 fix extension startup in tests, remote delayed startup pref → Bug 1753308 fix extension startup in tests, remove delayed startup pref
Pushed by scaraveo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e3886e3f90f9 fix extension startup in tests, remove delayed startup pref r=rpl,robwu
Comment 7•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox99:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•