Closed Bug 1753332 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 32668 - [webcodecs] Support odd visibleRects

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox99 fixed)

Status:
RESOLVED FIXED
Milestone:
99 Branch
Tracking Flags:
Tracking Status
firefox99 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32668 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32668
Details from upstream follow.

Dan Sanders <sandersd@chromium.org> wrote:

[webcodecs] Support odd visibleRects

Per https://github.com/w3c/webcodecs/issues/348#issuecomment-963517305,
Allow visibleRect to have odd size but not offset. Continue to restrict
copyTo() to even sizes.

Bug: 1205166
Change-Id: If6541a16a3852545634407c314530aaf40dc8e93
Reviewed-on: https://chromium-review.googlesource.com/3293782
WPT-Export-Revision: 01240cf17ac3478a1c0521ac2b405969d863a125

PR 32668 applied with additional changes from upstream: e4fd9b008a5de96b579c3512b6ffb9dd3cd98b59

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 27 subtests

Status Summary

Firefox

OK : 2
PASS: 1
FAIL: 53

Chrome

OK : 2
PASS: 52
FAIL: 2

Safari

OK : 2
PASS: 1
FAIL: 53

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/videoFrame-construction.any.html
Test we can construct a VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test closed VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct a VideoFrame with a negative timestamp.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct an odd-sized VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing w/ unusable image argument throws: HAVE_NOTHING <video>.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing w/ unusable image argument throws: emtpy Canvas.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing w/ unusable image argument throws: closed ImageBitmap.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing w/ unusable image argument throws: closed VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid CanvasImageSource constructed VideoFrames: FAIL (Chrome: PASS, Safari: FAIL)
Test visibleRect metadata override where source display size = visible size: FAIL (Chrome: PASS, Safari: FAIL)
Test visibleRect metadata override where source display width = 2 * visible width (anamorphic): FAIL (Chrome: PASS, Safari: FAIL)
Test visibleRect metadata override where source display size = 2 * visible size for both width and height: FAIL (Chrome: PASS, Safari: FAIL)
Test visibleRect + display size metadata override: FAIL (Chrome: PASS, Safari: FAIL)
Test display size metadata override: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid buffer constructed VideoFrames: FAIL (Chrome: PASS, Safari: FAIL)
Test Uint8Array(ArrayBuffer) constructed I420 VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test ArrayBuffer constructed I420 VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test planar constructed I420 VideoFrame with colorSpace: FAIL (Chrome: PASS, Safari: FAIL)
Test buffer constructed I420+Alpha VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test buffer constructed NV12 VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test buffer constructed RGB VideoFrames: FAIL (Chrome: PASS, Safari: FAIL)
Test VideoFrame constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct a VideoFrame from an offscreen canvas.: FAIL (Chrome: PASS, Safari: FAIL)
Test I420 VideoFrame with odd visible size: FAIL (Chrome: FAIL, Safari: FAIL)
Test I420A VideoFrame and alpha={keep,discard}: FAIL (Chrome: PASS, Safari: FAIL)
Test RGBA, BGRA VideoFrames with alpha={keep,discard}: FAIL (Chrome: PASS, Safari: FAIL)
Test a VideoFrame constructed from canvas can drop the alpha channel.: FAIL (Chrome: PASS, Safari: FAIL)
/webcodecs/videoFrame-construction.any.worker.html
Test we can construct a VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test closed VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct a VideoFrame with a negative timestamp.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct an odd-sized VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing w/ unusable image argument throws: emtpy Canvas.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing w/ unusable image argument throws: closed ImageBitmap.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing w/ unusable image argument throws: closed VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid CanvasImageSource constructed VideoFrames: FAIL (Chrome: PASS, Safari: FAIL)
Test visibleRect metadata override where source display size = visible size: FAIL (Chrome: PASS, Safari: FAIL)
Test visibleRect metadata override where source display width = 2 * visible width (anamorphic): FAIL (Chrome: PASS, Safari: FAIL)
Test visibleRect metadata override where source display size = 2 * visible size for both width and height: FAIL (Chrome: PASS, Safari: FAIL)
Test visibleRect + display size metadata override: FAIL (Chrome: PASS, Safari: FAIL)
Test display size metadata override: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid buffer constructed VideoFrames: FAIL (Chrome: PASS, Safari: FAIL)
Test Uint8Array(ArrayBuffer) constructed I420 VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test ArrayBuffer constructed I420 VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test planar constructed I420 VideoFrame with colorSpace: FAIL (Chrome: PASS, Safari: FAIL)
Test buffer constructed I420+Alpha VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test buffer constructed NV12 VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test buffer constructed RGB VideoFrames: FAIL (Chrome: PASS, Safari: FAIL)
Test VideoFrame constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct a VideoFrame from an offscreen canvas.: FAIL (Chrome: PASS, Safari: FAIL)
Test I420 VideoFrame with odd visible size: FAIL (Chrome: FAIL, Safari: FAIL)
Test I420A VideoFrame and alpha={keep,discard}: FAIL (Chrome: PASS, Safari: FAIL)
Test RGBA, BGRA VideoFrames with alpha={keep,discard}: FAIL (Chrome: PASS, Safari: FAIL)
Test a VideoFrame constructed from canvas can drop the alpha channel.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eebd1e7afcc4 [wpt PR 32668] - [webcodecs] Support odd visibleRects, a=testonly https://hg.mozilla.org/integration/autoland/rev/7a66ff1b4ae7 [wpt PR 32668] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9349a309cb68 [wpt PR 32668] - [webcodecs] Support odd visibleRects, a=testonly https://hg.mozilla.org/integration/autoland/rev/a178634a55ef [wpt PR 32668] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9349a309cb68
https://hg.mozilla.org/mozilla-central/rev/a178634a55ef

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox99: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.