1753335 - Assertion failure: line (aStartLine out of range), at src/layout/generic/nsLineBox.cpp:579

Status: NEW

(Core :: Layout: Block and Inline, defect)

Description

[Tyson Smith [:tsmith]]

Attachment: testcase.html

Found while fuzzing m-c 20220202-b24a501652eb (--enable-debug --enable-fuzzing)

To reproduce via Grizzly Replay:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch -d --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html --xvfb

Assertion failure: line (aStartLine out of range), at src/layout/generic/nsLineBox.cpp:579

#0 0x7f85e4e8bb92 in nsLineIterator::FindLineContaining(nsIFrame*, int) src/layout/generic/nsLineBox.cpp:579:3
#1 0x7f85e4c622e1 in AccumulateFrameBounds src/layout/base/PresShell.cpp:3357:33
#2 0x7f85e4c622e1 in mozilla::PresShell::DoScrollContentIntoView() src/layout/base/PresShell.cpp:3665:7
#3 0x7f85e4c6548b in mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) src/layout/base/PresShell.cpp:4301:11
#4 0x7f85e1ac8da0 in FlushPendingNotifications /builds/worker/workspace/obj-build/dist/include/mozilla/PresShell.h:1448:5
#5 0x7f85e1ac8da0 in mozilla::dom::Document::FlushPendingNotifications(mozilla::ChangesToFlush) src/dom/base/Document.cpp:10746:16
#6 0x7f85e4c61c3e in mozilla::PresShell::ScrollContentIntoView(nsIContent*, mozilla::ScrollAxis, mozilla::ScrollAxis, mozilla::ScrollFlags) src/layout/base/PresShell.cpp:3570:16
#7 0x7f85e1b058b1 in mozilla::dom::Element::ScrollIntoView(mozilla::dom::ScrollIntoViewOptions const&) src/dom/base/Element.cpp:767:14
#8 0x7f85e1b056a0 in mozilla::dom::Element::ScrollIntoView(mozilla::dom::BooleanOrScrollIntoViewOptions const&) src/dom/base/Element.cpp
#9 0x7f85e2d2da03 in mozilla::dom::Element_Binding::scrollIntoView(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) /builds/worker/workspace/obj-build/dom/bindings/ElementBinding.cpp:3188:24
#10 0x7f85e303d638 in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) src/dom/bindings/BindingUtils.cpp:3306:13
#11 0x7f85e6b10c3f in CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) src/js/src/vm/Interpreter.cpp:425:13
#12 0x7f85e6b1033d in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) src/js/src/vm/Interpreter.cpp:512:12
#13 0x7f85e6b11e1e in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) src/js/src/vm/Interpreter.cpp:572:10
#14 0x7f85e6b076d6 in CallFromStack src/js/src/vm/Interpreter.cpp:576:10
#15 0x7f85e6b076d6 in Interpret(JSContext*, js::RunState&) src/js/src/vm/Interpreter.cpp:3309:16
#16 0x7f85e6afe5d3 in js::RunScript(JSContext*, js::RunState&) src/js/src/vm/Interpreter.cpp:394:13
#17 0x7f85e6b10238 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) src/js/src/vm/Interpreter.cpp:544:13
#18 0x7f85e6b11e1e in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) src/js/src/vm/Interpreter.cpp:572:10
#19 0x7f85e6b12021 in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) src/js/src/vm/Interpreter.cpp:589:8
#20 0x7f85e6cd0601 in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) src/js/src/vm/CallAndConstruct.cpp:117:10
#21 0x7f85e2d5c89c in mozilla::dom::EventHandlerNonNull::Call(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::dom::Event&, JS::MutableHandle<JS::Value>, mozilla::ErrorResult&) /builds/worker/workspace/obj-build/dom/bindings/EventHandlerBinding.cpp:283:37
#22 0x7f85e35312d9 in void mozilla::dom::EventHandlerNonNull::Call<nsCOMPtr<mozilla::dom::EventTarget> >(nsCOMPtr<mozilla::dom::EventTarget> const&, mozilla::dom::Event&, JS::MutableHandle<JS::Value>, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*) /builds/worker/workspace/obj-build/dist/include/mozilla/dom/EventHandlerBinding.h:365:12
#23 0x7f85e353048d in mozilla::JSEventHandler::HandleEvent(mozilla::dom::Event*) src/dom/events/JSEventHandler.cpp:201:12
#24 0x7f85e35114fb in mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*) src/dom/events/EventListenerManager.cpp:1314:22
#25 0x7f85e35121b9 in mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool) src/dom/events/EventListenerManager.cpp:1505:17
#26 0x7f85e35071b4 in HandleEvent src/dom/events/EventListenerManager.h:395:5
#27 0x7f85e35071b4 in mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) src/dom/events/EventDispatcher.cpp:348:17
#28 0x7f85e35066d7 in mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) src/dom/events/EventDispatcher.cpp:550:16
#29 0x7f85e3508f38 in mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) src/dom/events/EventDispatcher.cpp:1085:11
#30 0x7f85e4cda423 in nsDocumentViewer::LoadComplete(nsresult) src/layout/base/nsDocumentViewer.cpp:1084:7
#31 0x7f85e630ad84 in nsDocShell::EndPageLoad(nsIWebProgress*, nsIChannel*, nsresult) src/docshell/base/nsDocShell.cpp:6403:20
#32 0x7f85e630a873 in nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) src/docshell/base/nsDocShell.cpp:5792:7
#33 0x7f85e630b70f in non-virtual thunk to nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) src/docshell/base/nsDocShell.cpp
#34 0x7f85e10fa15c in nsDocLoader::DoFireOnStateChange(nsIWebProgress*, nsIRequest*, int&, nsresult) src/uriloader/base/nsDocLoader.cpp:1377:3
#35 0x7f85e10f96ea in nsDocLoader::doStopDocumentLoad(nsIRequest*, nsresult) src/uriloader/base/nsDocLoader.cpp:975:14
#36 0x7f85e10f7a70 in nsDocLoader::DocLoaderIsEmpty(bool, mozilla::Maybe<nsresult> const&) src/uriloader/base/nsDocLoader.cpp:794:9
#37 0x7f85e10f8c2d in nsDocLoader::OnStopRequest(nsIRequest*, nsresult) src/uriloader/base/nsDocLoader.cpp:677:5
#38 0x7f85e632c50d in nsDocShell::OnStopRequest(nsIRequest*, nsresult) src/docshell/base/nsDocShell.cpp:13702:23
#39 0x7f85dfe5b3ca in mozilla::net::nsLoadGroup::NotifyRemovalObservers(nsIRequest*, nsresult) src/netwerk/base/nsLoadGroup.cpp:614:22
#40 0x7f85dfe5c9b3 in mozilla::net::nsLoadGroup::RemoveRequest(nsIRequest*, nsISupports*, nsresult) src/netwerk/base/nsLoadGroup.cpp:518:10
#41 0x7f85e1ace125 in mozilla::dom::Document::DoUnblockOnload() src/dom/base/Document.cpp:11554:18
#42 0x7f85e1a98c83 in mozilla::dom::Document::UnblockOnload(bool) src/dom/base/Document.cpp:11484:9
#43 0x7f85e1ab4b4b in mozilla::dom::Document::DispatchContentLoadedEvents() src/dom/base/Document.cpp:7999:3
#44 0x7f85e1b65fab in applyImpl<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1147:12
#45 0x7f85e1b65fab in apply<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1153:12
#46 0x7f85e1b65fab in mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1200:13
#47 0x7f85dfc5f912 in mozilla::SchedulerGroup::Runnable::Run() src/xpcom/threads/SchedulerGroup.cpp:140:20
#48 0x7f85dfc8fc9e in mozilla::RunnableTask::Run() src/xpcom/threads/TaskController.cpp:467:16
#49 0x7f85dfc69aa6 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) src/xpcom/threads/TaskController.cpp:770:26
#50 0x7f85dfc68768 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) src/xpcom/threads/TaskController.cpp:606:15
#51 0x7f85dfc689e3 in mozilla::TaskController::ProcessPendingMTTask(bool) src/xpcom/threads/TaskController.cpp:390:36
#52 0x7f85dfc92cd6 in operator() src/xpcom/threads/TaskController.cpp:124:37
#53 0x7f85dfc92cd6 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:531:5
#54 0x7f85dfc7e3f3 in nsThread::ProcessNextEvent(bool, bool*) src/xpcom/threads/nsThread.cpp:1195:16
#55 0x7f85dfc854da in NS_ProcessNextEvent(nsIThread*, bool) src/xpcom/threads/nsThreadUtils.cpp:467:10
#56 0x7f85e0726046 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) src/ipc/glue/MessagePump.cpp:85:21
#57 0x7f85e064ada7 in MessageLoop::RunInternal() src/ipc/chromium/src/base/message_loop.cc:331:10
#58 0x7f85e064acb2 in RunHandler src/ipc/chromium/src/base/message_loop.cc:324:3
#59 0x7f85e064acb2 in MessageLoop::Run() src/ipc/chromium/src/base/message_loop.cc:306:3
#60 0x7f85e49319a8 in nsBaseAppShell::Run() src/widget/nsBaseAppShell.cpp:137:27
#61 0x7f85e6994913 in XRE_RunAppShell() src/toolkit/xre/nsEmbedFunctions.cpp:878:20
#62 0x7f85e0726f3a in mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) src/ipc/glue/MessagePump.cpp:235:9
#63 0x7f85e064ada7 in MessageLoop::RunInternal() src/ipc/chromium/src/base/message_loop.cc:331:10
#64 0x7f85e064acb2 in RunHandler src/ipc/chromium/src/base/message_loop.cc:324:3
#65 0x7f85e064acb2 in MessageLoop::Run() src/ipc/chromium/src/base/message_loop.cc:306:3
#66 0x7f85e6993f4c in XRE_InitChildProcess(int, char**, XREChildData const*) src/toolkit/xre/nsEmbedFunctions.cpp:715:34
#67 0x55681e2d8029 in content_process_main src/browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
#68 0x55681e2d8029 in main src/browser/app/nsBrowserApp.cpp:327:18
#69 0x7f85f4ac60b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16
#70 0x55681e2b37bc in _start (/home/worker/builds/m-c-20220202093701-fuzzing-debug/firefox-bin+0x157bc)

Comment 1

[Tyson Smith [:tsmith]]

A Pernosco session is available here: https://pernos.co/debug/luPx-mGtpBuiKFOs7kVYvA/index.html

Comment 2

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Verified bug as reproducible on mozilla-central 20220203003951-5ec687bd6a86.
The bug appears to have been introduced in the following build range:

Start: b7e093b6de1a9b804b60954326d94d6203b277a7 (20211109143617)
End: 7f484174dd5199b28b2240afb975c33a695890be (20211109164025)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b7e093b6de1a9b804b60954326d94d6203b277a7&tochange=7f484174dd5199b28b2240afb975c33a695890be

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:TYLin, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I can further reduce the range in comment 2 down to Bug 1732674 in a local mozregression run. https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bea1d2e7975873b42df679486c109c904b68bf40&tochange=51e1fef63b7be88e8a0b0944134a60ef72f89667

Jonathan, could you take a look?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1732674

Comment 6

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Testcase crashes using the initial build (mozilla-central 20220202093701-b24a501652eb) but not with tip (mozilla-central 20220812214215-fbae7216fa06.)

The bug appears to have been fixed in the following build range:

Start: bdb42cfe62138374343d5be83ac208826812cd2d (20220810161147)
End: a5ef26cc165936d1c01c42c0e5d2c597ebcc5a8f (20220810181917)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bdb42cfe62138374343d5be83ac208826812cd2d&tochange=a5ef26cc165936d1c01c42c0e5d2c597ebcc5a8f

tsmith, can you confirm that the above bisection range is responsible for fixing this issue?
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 7

[Tyson Smith [:tsmith]]

The test case now triggers bug 1772914. We can retest once it is resolved.