1753401 - PiP not working on Hulu

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Catalin Sasca, Desktop QA [:csasca]]

Affected versions

• Firefox 97.0
• Firefox 98.0a1

Affected platforms

• Windows 7
• macOS 11.6.3
• Ubuntu 20.04

Steps to reproduce

1. Launch Firefox
2. Access Hulu and login
3. Select any video and play it
4. Click on PiP icon

Expected result

• The video is played in PiP mode

Actual result

• The video is paused

Regression range

• Will see for a regression

Additional notes

• The issue can be seen in the following attachment
• PiP will work only if the video is minimized first from the player controls

Comment 1

[Catalin Sasca, Desktop QA [:csasca]]

Searched for regression and it seems it was introduced between 2022-01-03 and 04.
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=85a1717fd579a0dbbf5e16a08dcbeee5a64f77fd&tochange=ba0ff402e454c72ede8868c249eabfd9d47e68ba

Bug 1742585 - Add PiP toggle visibility threshold preference

Comment 2

[Micah [:mtigley] (she/her)]

:csasca, is the issue fixed if you change the media.videocontrols.picture-in-picture.video-toggle.visibility-threshold preference to 1.0?

If that's the case, then this might require for Hulu to have its own PiP override, similar to what we do for youtube. Or we may need to increase that preference value back to 1.0.

Comment 3

[Catalin Sasca, Desktop QA [:csasca]]

Hey Micah, tried changing the pref to 1.0 and it seems to have resolved the issue on latest nightly 98.0a1.

Comment 4

[Micah [:mtigley] (she/her)]

Attachment: Bug 1753401 - Change PiP toggle's visibility threshold back to 1.0. r=mhowell!

Comment 5

[Micah [:mtigley] (she/her)]

Comment on attachment 9262947 [details]
Bug 1753401 - Change PiP toggle's visibility threshold back to 1.0. r=mhowell!

Beta/Release Uplift Approval Request

• User impact if declined: Users won't be able to use the PiP toggle button on Hulu.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small adjustment to the existing pref
• String changes made/needed:

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70ea492ad245
Change PiP toggle's visibility threshold back to 1.0. r=mhowell

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/70ea492ad245

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9262947 [details]
Bug 1753401 - Change PiP toggle's visibility threshold back to 1.0. r=mhowell!

Uplift approved for 98 beta 3, thanks.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a20590328570

Comment 10

[Ardelean Oana, Desktop QA [:oardelean]]

This issue is reproducible on Firefox 97.0, Firefox 98.0b2 and Nightly 98.0a1 on Linux(Ubuntu 20.04). Fixed on Nightly 99.0a1 and the upcoming 98.0b3( downloaded from treeherder) on all platforms.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9262947 [details]
Bug 1753401 - Change PiP toggle's visibility threshold back to 1.0. r=mhowell!

Approved for 97.0.1. Do we have a bug for making this a site-specific workaround for the future?

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/1c55cf2acedc

Comment 13

[Micah [:mtigley] (she/her)]

Yes, we've got a bug on file in bug 1754604

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Added to the 97.0.1 release notes.

Fixed an issue which led to Picture-in-Picture mode being unable to be toggled on Hulu

Comment 15

[Ardelean Oana, Desktop QA [:oardelean]]

Verified on Firefox 97.0.1(20220216172458) on macOS Big Sur 11, Linux(Ubuntu 20.04) and Win7. PiP is working now.