Additions to jst-review.pl

RESOLVED INVALID

Status

()

P3
enhancement
RESOLVED INVALID
16 years ago
12 years ago

People

(Reporter: john, Assigned: john)

Tracking

Details

(Assignee)

Description

16 years ago
This bug is to track additions and suggestions to jst-review-cgi.pl.  If this
bug gets too out of hand we will split them.

Do not use this bug to complain about removing existing style rules.
(Assignee)

Comment 1

16 years ago
if (NS_FAILED(rv)) { return x; } -> NS_ENSURE_SUCCESS(rv, x);

else-after-return rule has wrong explanation--real reason is to keep indentation
down.

From caillon: yell at people who use nsIPref (temp measure until it is removed
entirely) using the strings: nsIPref.h NS_PREF_CONTRACTID NS_PREF_CID
NS_PREF_CLASSNAME "@mozilla.org/preferences;1"
Depends on: 167056
pardon my ignorance, but what exactly is jst-review.pl?  I don't see any files
by that name in Bugzilla.
(Assignee)

Comment 3

16 years ago
See bug 167056--the plan is to integrate into Bugzilla. 
http://www.johnkeiser.com/cgi-bin/jst-review-cgi.pl is its current name.
John, until we get your code integrated into Bugzilla probably the best thing to
do is post this stuff as attachments to bug 167056.
(Assignee)

Comment 5

16 years ago
Also, "&" at the beginning of a line is not always bad.  Sometimes it's a unary
operator.  Same with "-".
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → Future
(Assignee)

Comment 6

15 years ago
From sicking: NS_ENSURE_TRUE after new X() does not count as a null check
':' at the beginning of a line might not be an operator but rather the start of
an initializer list
/me wants to listen in :-)
Severity: normal → enhancement

Updated

12 years ago
QA Contact: mattyt-bugzilla → default-qa

Comment 9

12 years ago
Marking this bug INVALID as jst-review-cgi.pl never landed. If you want to implement such a script, use bug 167056.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → INVALID
Target Milestone: Future → ---
You need to log in before you can comment on or make changes to this bug.