1753621 - mac upload-symbols missing from nightly graph

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Julien Cristau [:jcristau]]

When builds are not scheduled on push (as happens frequently since bug 1748581), we need the nightly cron decision task to add them.
For mac this goes through https://searchfox.org/mozilla-central/rev/bb14d901ac16633801b7f4adaa4fb104e6f072e4/taskcluster/gecko_taskgraph/target_tasks.py#855

Our upload-symbols tasks for mac shippable builds are build-macosx64-aarch64-shippable/opt-upload-symbols and build-macosx64-x64-shippable/opt-upload-symbols, with corresponding macosx64-aarch64-shippable and macosx64-x64-shippable build platforms, so they are not included in the macosx64-shippable filter and don't get scheduled in that case.

Comment 1

[Julien Cristau [:jcristau]]

A secondary reason they're excluded is the x64 and aarch64 build tasks don't have the shippable attribute, thus the upload-symbols tasks don't have it either, and make_desktop_nightly_filter looks for that.

Comment 2

[Julien Cristau [:jcristau]]

Attachment: Bug 1753621 - WIP: upload symbols from unified mac build.

Comment 4

[Steven Michaud [:smichaud] (Retired)]

Bug 1755007 is probably not a dup of this bug. Its symptoms have disappeared, at least temporarily. But this bug remains unfixed.

See bug 1755007 comment #3.

Comment 5

[Julien Cristau [:jcristau]]

Attachment: Bug 1753621 - add upload-symbols-dummy task kind to handle macosx.

Without this, the desktop nightly graph does not include upload-symbols
tasks for mac, because these tasks don't have the macosx64-shippable
build_platform due to the split x64 / aarch64 build.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67bfc6149fb8
add upload-symbols-dummy task kind to handle macosx. r=releng-reviewers,aki

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/67bfc6149fb8

Comment 8

[Steven Michaud [:smichaud] (Retired)]

(Following up comment #4)

The patch for this bug seems to have fixed bug 1755007. So bug 1755007 really is a duplicate of this bug. See bug 1755007 comment #5.

Comment 9

[Julien Cristau [:jcristau]]

Attachment: Ensure pinebuild mac symbols are uploaded to the symbols server

This ports the change from bug 1753621 over to pinebuild.