1753751 - After quitting vim, file contents remain visible

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, defect)

Description

[Mitchell Hentges [:mhentges] 🦀]

Attachment: vim-garbage.png

To reproduce

1. vi /etc/bash/bash.bashrc
2. !q
3. See attached image

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Seems to be related to the TERM=cygwin workaround for hg colouring.

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

We can remove the TERM=cygwin workaround by resolving that issue a different way.

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1753751: Fix vim-quitting not fully cleaning up terminal

The vim-clearing issue was caused by our changing of $TERM to be
cygwin instead of the upstream default of xterm-256color.

That $TERM change was to avoid an hg bug [1] around detecting the
color mode, which assumed that any terminal that had "xterm" in the
$TERM was coloured with ansi sequences.

Fortunately, that can be worked around by explicitly setting the
color.mode in the mercurial.ini that we ship.

Note that this doesn't break compatibility with Mintty: hg output
appears to still be properly coloured.

[1] https://bz.mercurial-scm.org/show_bug.cgi?id=6640

Depends on D137905

Comment 4

[Mitchell Hentges [:mhentges] 🦀]

Upstream patch made for HG here.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-build/rev/c840f94df32a
Fix vim-quitting not fully cleaning up terminal r=glandium

Comment 6

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1753751: Remove hg TERM workaround

As of mercurial==6.1, the issue with hg coloring not
working with xterm-y Command Prompts has been resolved:
https://bz.mercurial-scm.org/show_bug.cgi?id=6640

Depends on D140350

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-build/rev/80cb06733571
Remove hg TERM workaround r=ahochheiden