Closed Bug 1753891 Opened 2 years ago Closed 2 years ago

MsgFilterList(args) should take targetFilter and pass it to FilterListDialog

Categories

(SeaMonkey :: MailNews: Backend, enhancement)

enhancement
Not set
normal

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
seamonkey 2.96
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.11)

Attachments

(1 file)

Porting Bug 1002006 to SeaMonkey.
It should be possible to preselect a specific filter by adding
args.filter = targetFilter;

before calling MsgFilterList(args)

It would also be good if we had a mechanism to select a filter when the filter dialog is already open.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: New filter is not selected if filter dialog is already open
Testing completed (on m-c, etc.): 2.53.11
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9262552 - Flags: review?(frgrahl)
Attachment #9262552 - Flags: approval-comm-release?
Attachment #9262552 - Flags: approval-comm-esr60?

Comment on attachment 9262552 [details] [diff] [review]
1753891-fld-pass-filter-25311.patch

LGTM

Attachment #9262552 - Flags: review?(frgrahl)
Attachment #9262552 - Flags: review+
Attachment #9262552 - Flags: approval-comm-release?
Attachment #9262552 - Flags: approval-comm-release+
Attachment #9262552 - Flags: approval-comm-esr60?
Attachment #9262552 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/e8c6cf6e7215
MsgFilterList(args) should take targetFilter and pass it to FilterListDialog. r=frg

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.11
Target Milestone: --- → seamonkey 2.96
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: