Closed Bug 1753915 Opened 3 years ago Closed 2 years ago

Add debug logging subsystem to ASRouter

Categories

(Firefox :: Messaging System, task, P1)

Product:
Firefox
Component:
Messaging System
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
103 Branch
Iteration:
103.1 - May 30 - June 10
Tracking Flags:
Tracking Status
firefox103 --- fixed

People

(Reporter: dmosedale, Assigned: dmosedale)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1753915 - Add logging to ASRouter, r?barret
48 bytes, text/x-phabricator-request
Details | Review

Right now, debugging stuff in ASRouter can be extremely slow going in part because of all the asynchony, lots of it event-driven.

I've used Console.jsm to create an ASRouter logging subsystem, and added a bunch of logging which helped me sort out some existing test failures.

It's still a work-in-progress, but it is likely useful in concert with other patches, even as is.

Severity: -- → N/A
Priority: -- → P1
Iteration: --- → 99.1 - Feb 7 - Feb 20
Summary: ASRouter needs debug logging → Add debug logging to ASRouter
Summary: Add debug logging to ASRouter → Add debug logging subsystem to ASRouter
Iteration: 99.1 - Feb 7 - Feb 20 → 99.2 - Feb 21 - Mar 6
Priority: P1 → P2
Iteration: 99.2 - Feb 21 - Mar 6 → 100.1 - March 1 - March 18
Iteration: 100.1 - March 1 - March 18 → 100.2 - March 21 - April 1
Iteration: 100.2 - March 21 - April 1 → 101.1 - April 4 - April 15
Iteration: 101.1 - April 4 - April 15 → 102.1 - May 2 - May 13
Iteration: 102.1 - May 2 - May 13 → 102.2 - May 16 - May 27
Iteration: 102.2 - May 16 - May 27 → ---
Attachment #9262579 - Attachment description: WIP: Bug 1753915 - Add logging to ASRouter → Bug 1753915 - Add logging to ASRouter, r?barret
Status: NEW → ASSIGNED
Iteration: --- → 103.1 - May 30 - June 10
Priority: P2 → P1

Backed out for causing newtab node failures

Backout link

Push with failures

Failure log

Flags: needinfo?(dmosedale)

Fixed patch now up for review.

Flags: needinfo?(dmosedale)

https://hg.mozilla.org/mozilla-central/rev/ad4941053edd

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: