1753923 - Remove run-time selection of wasm SIMD

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Lars T Hansen [:lth]]

SIMD has shipped and seems stable and I don't think we need the run-time switches any more:

• javascript.options.wasm_simd in about:config
• --no-wasm-simd at the shell

These should probably be removed (or we should understand why they are still needed). All code in the engine that tests this setting should be removed.

The TestingFunctions.cpp predicate and the ifdef remain, since we don't have SIMD on all platforms.

Removing the --no-wasm-simd switch may require another "state" in public/WasmFeatures.h, so there's a little bit of design work. (Edit: it probably just means removing SIMD from WasmFeatures.h)

Obviously this is not urgent, it's just cleanup that should be done to simplify the code.

Comment 1

[Yury Delendik (:yury)]

Attachment: Bug 1753923 - Remove run-time selection of wasm SIMD. r?rhunt

Removed:

• javascript.options.wasm_simd in about:config
• --no-wasm-simd at the shell

Comment 2

[Yury Delendik (:yury)]

Some element of runtime selection will still exist because of ability to control js shell SIMD e.g. via --no-sse3 -- will hide this deep inside js::wasm::FeatureArgs.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3dbbd5f2fd8
Remove run-time selection of wasm SIMD. r=rhunt

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/c3dbbd5f2fd8