1753932 - Investigate which preference(s) are written late

Status: RESOLVED FIXED

(Core :: Preferences: Backend, task)

Description

[Jens Stutte [:jstutte]]

In pref_SetPref we added a check for late-in-shutdown preference write attempts.

Based on bug 1752308 comment 8 we might want to add better diagnostics in debug builds to see where those late attempts come from. IIUC we want to:

• re-introduce the debug assertion we initially had
• add additional information (JS stack) to the log output

Comment 1

[Jens Stutte [:jstutte]]

Attachment: Bug 1753932: Add JS stack dump and debug assertion on late preference writes. r?gijs

Comment 2

[Jens Stutte [:jstutte]]

This patch will most likely cause new intermittents similar to bug 1752308. Thus we can close this one when the patch lands and wait for those to appear.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bc4dbac64bb
Add JS stack dump and debug assertion on late preference writes. r=Gijs

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6bc4dbac64bb