GC dependence on reason codes is surprising
Categories
(Core :: JavaScript: GC, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(3 files)
Currently the GC behaves differently depending on the trigger reason (e.g. for shutdown GCs). This is pretty surprising. We should make this behaviour explicit by requiring the caller to pass an option rather than interpreting the reason code.
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
This removes the ugly passing around of MaybeGCOptions which didn't end up up
working out that well.
We now set the options when we start a GC. They're stored as a maybe and we
assert they are set during incremental GC and clear then at the end.
|
|
Assignee | |
Comment 2•3 years ago
|
||
This also makes the method assert if called outside and incremental GC rather
than always returning false.
Depends on D138553
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D138554
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c17e98d44b5b Part 1: Refactor handling of GCOptions r=sfink https://hg.mozilla.org/integration/autoland/rev/f940de51af34 Part 2: Use isShrinkingGC() method rather than checking the options directly r=sfink https://hg.mozilla.org/integration/autoland/rev/3d9247af11fa Part 3: Add a GCOption for shutdown GCs and use this rather than checking the GCReason r=sfink,mccr8
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c17e98d44b5b
https://hg.mozilla.org/mozilla-central/rev/f940de51af34
https://hg.mozilla.org/mozilla-central/rev/3d9247af11fa
Description
•