Closed Bug 1753979 Opened 2 years ago Closed 6 months ago

Consider increasing the number of DNS resolver threads.

Categories

(Core :: Networking: DNS, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
firefox122 --- fixed

People

(Reporter: valentin, Assigned: valentin)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [necko-triaged])

Attachments

(2 files)

The number of parallel DNS resolutions is currently limited to 8 It has been so pretty much for since 2008.

As Brian noticed, Chrome has recently increased these limits.

This bug requires an investigation into doing the same.

Whiteboard: [necko-triaged]
Performance Impact: --- → ?

Not sure setting a perf impact is appropriate, as we can't really tell right now what the impact would be.

But umm, can't we just double the number on nightly and look at telemetry? It feels like this shouldn't be super-hard. Maybe something Marc could do? What do you think Dragana?

Performance Impact: ? → ---
Flags: needinfo?(dd.mozilla)

Yes, we are planning to perform such an experiment.

Flags: needinfo?(dd.mozilla)
Depends on: 1812009

For native dns queries, I believe the probe dns_native_queuing collects the delay.
0 ms, but 32 ms at 95th percentile.

Depends on: 1840441

The new threadpool will have 40 threads dedicated to High priority DNS
requests, and 24 for any priority DNS requests leading to a total of 64.

The recent DNS thread count experiment validates that this value is
reasonable and reduces the values of dns_native_queuing in the 95, 99 and 99.9
percentiles (all others being 0).

Moreover this has limited impact on memory usage, since this high thread
limit is only reached in times when a lot of DNS requests are made.
Normal browsing will hit this limit infrequently.

Assignee: nobody → valentin.gosu
Status: NEW → ASSIGNED
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8a43a8a71dca
Increase number of DNS resolver threads to 64 r=necko-reviewers,kershaw
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch

Valentin shipped the configuration from treatment-a of the experiment.
From examining the nimbus experiment results (release) we can see the greatly reduced queuing time below, 95% and 99% percentiles:

control
0.95   26ms
0.99  816ms

treatment-a 
0.95    3ms
0.99  345ms

Query here.

Attached image image.png

DNS_NATIVE_QUEUING on Nightly reflects the same improvement since we landed this.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: