1754041 - [wpt-sync] Sync PR 32730 - [LayoutNG] Add PropagateChildBreakValues flag to the ConstraintSpace

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32730 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32730
Details from upstream follow.

Alison Maher <[e-mail]> wrote:

[LayoutNG] Add PropagateChildBreakValues flag to the ConstraintSpace

This CL adds a new flag to the ConstraintSpace to propagate child break
values (initial-break-before and previous-break-after).

The flag is currently set when setting the fragmentation type. However,
it will also be used in future changes outside of the normal
fragmentation pass to determine the initial-break-before and
final-break-after for rows.

The code that performs child break value propagation in
MovePastBreakpoint() was moved to the builder, and it is run
whenever the new flag is set to true.

This fixed a bug where we failed to propagate up the break values of
a child if there was no BFC block-offset. The reason was that we
never called BreakBeforeChildIfNeeded() in that case. By moving the
propagation to the builder, instead, we can ensure the break values
are correctly propagated in this case, as well.

Bug: 829028,1293291
Change-Id: I2afd288cad99d11a1c414aca5844d7a77afef46f
Reviewed-on: https://chromium-review.googlesource.com/3433832
WPT-Export-Revision: f99d5409f250a5cdcc02fe1b20bff455c8da6167

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=62211cf9a97928e961ca0c834d1ce98f32eab3f7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

FAIL: 3

Chrome

PASS: 2
FAIL: 1

Safari

PASS: 2
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/break-between-force-001.html: FAIL
/css/css-break/break-between-force-002.html: FAIL

New Tests That Don't Pass

/css/css-break/break-between-avoid-010.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/break-between-force-001.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/break-between-force-002.html: FAIL (Chrome: PASS, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f2d7b79a9fa
[wpt PR 32730] - [LayoutNG] Add PropagateChildBreakValues flag to the ConstraintSpace, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b37922a420d3
[wpt PR 32730] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5ca5a9b5c35
[wpt PR 32730] - [LayoutNG] Add PropagateChildBreakValues flag to the ConstraintSpace, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c83bff17cad8
[wpt PR 32730] - Update wpt metadata, a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c5ca5a9b5c35
https://hg.mozilla.org/mozilla-central/rev/c83bff17cad8