1754115 - create new private browsing string_id so we can get rid of "Dismiss" in favor of "Close"

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

For the en-US only VPN experiment for 98, we've temporarily hard-coded the title of the "Close" button. The comment I added to the source:

  <!-- XXX The tooltip for the close button is intended to change to "Close" (it is currently
    -- "Dismiss"). The string change missed 98 Nightly; however, this UI is only surfaced in
    -- an experiment, and the experiment for 98 will be US-only.  So for now, we're
    -- hard-coding this string in the "title" attribute.
    --
    -- Bug 1754115 is already filed to do the right thing for 99, which is to get rid of this
    -- workaround, and replace the old string_id in 99 Nightly with a new one.  The intent
    -- is to land it on 99 Nightly right after this patch lands and is uplifted to 98. -->
  <button id="dismiss-btn" class="promo-dismiss" title="Close"></button>

Once that patch lands on mozilla-central 99, and is uplifted to 98, the next step is to fix
99 to do the right thing by giving that new string.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1754115 - switch pvt browsing promo close string, r?pdahiya

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c9a7ccd7e07
switch pvt browsing promo close string, r=pdahiya,fluent-reviewers

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7c9a7ccd7e07

Comment 4

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using Firefox Beta 99.0b4 (Build ID: 20220315185755) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.

• The tooltip shown when hovering the “x” button from the Promo messages on Private Windows contains the “Close” string.