1754266 - Eliminate preprocessor %includes from toolkit tree stylesheets

Status: RESOLVED FIXED

(Toolkit :: Themes, task)

Description

[Sam Foster [:sfoster] (he/him)]

Replace the %includes with either @import or by inlining the included stylesheet. See bug 1659584 for details. This bug should cover:

• toolkit/themes/{platform}/global/tree.css
  • toolkit/themes/shared/tree.inc.css

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1754266 - Fold platform-specific rules into a shared/tree.css. r?dao!

• Move the {platform}/gloal/tree.css contents into @media blocks in a shared/tree.css
• Move %ifdef XP_Win into the window @media block
• Adjust manifests to map chrome://browser/skin/tree.css to the shared/tree.css

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32895e903508
Fold platform-specific rules into a shared/tree.css. r=desktop-theme-reviewers,dao

Comment 3

[Cristian Tuns]

Backed out for causing mochitest failures on browser_parsable_css.js

• Backout link
• Push with failures
• Failure Log
• Failure line: PROCESS-CRASH | browser/base/content/test/static/browser_parsable_css.js | application crashed [@ CheckForBrokenChromeURL(nsILoadInfo*, nsIURI*)]

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1754266 - Teach browser_parsable_css.js about platform-specific queries. r=sfoster

This should sidestep the failure that got you backed out, though
untested :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab11d81ed132
Teach browser_parsable_css.js about platform-specific queries. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/bd62a132a687
Fold platform-specific rules into a shared/tree.css. r=desktop-theme-reviewers,dao

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/ab11d81ed132
https://hg.mozilla.org/mozilla-central/rev/bd62a132a687