1754305 - Upgrade Maybe assertions to MOZ_RELEASE_ASSERT

Status: RESOLVED FIXED

(Core :: MFBT, enhancement)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1754305 - Make assertions in Maybe MOZ_RELEASE_ASSERT, r=glandium

These assertions are already diagnostic asserts, and this will make
failures to check Maybe into safe crashes rather than security bugs on
all branches.

A failure to check Maybe is more dangerous than a null pointer
dereference, as the generated code will produce a valid reference to
uninitialized data rather than a null reference which should safely
segfault.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/baec998d3775
Make assertions in Maybe MOZ_RELEASE_ASSERT, r=glandium

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/baec998d3775

Comment 4

[Andrew McCreight [:mccr8]]

[Tracking Requested - why for this release]: It would be nice to uplift this to ESR, so they'll get the same benefit of these checks.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Nika, did you want to nominate this for uplift given comment 4? It grafts cleanly.

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 9262936 [details]
Bug 1754305 - Make assertions in Maybe MOZ_RELEASE_ASSERT, r=glandium

Beta/Release Uplift Approval Request

• User impact if declined: Increased severity of a class of crashes
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just upgrading some diagnostic asserts to release asserts
• String changes made/needed: N/A

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Easy to uplift patch which provides mildly increased security with very low risk
• User impact if declined: Increased severity of a class of crashes
• Fix Landed on Version: 99
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just upgrading some diagnostic asserts to release asserts

Comment 7

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9262936 [details]
Bug 1754305 - Make assertions in Maybe MOZ_RELEASE_ASSERT, r=glandium

Approved for 98 beta 7, thanks.

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/128269547c80

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9262936 [details]
Bug 1754305 - Make assertions in Maybe MOZ_RELEASE_ASSERT, r=glandium

Approved for 91.7esr.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/4f04e2ff2289