1754401 - Extension “Report Abuse” window is intermittently missing padding at the bottom

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Alex Cornestean]

Affected versions:
Nightly (99.0a1/20220208215108)
Beta (98.0b2/20220208185809)
Release (97.0/20220202182137)

[Affected platforms]:
Windows 10 x64
macOS

[Steps to reproduce]:

1. Go to the Addons Manager page and install any extension (for example, install any of the recommended extensions)
2. Go to the “Extensions” tab and report the previously installed extension multiple times (closing the Report Abuse window afterwards) via the “Report” option from the “three dot” menu.
3. Notice that on some occasions, the “Report Abuse” window will be missing some padding at the bottom, causing the “Cancel” and “Next” buttons to look cut-off.

Notes:

1. Continuing to report the same extension will only sometimes cause the “Report Abuse” window to have missing padding at the bottom. Once the issue occurs, reporting the extension again might cause the report window to be displayed properly or the issue to persist.
2. The issue can be triggered from each location extension reporting can be initiated:

• ”three dot” menu from the extension card
• “three dot” menu from the extension detail page
• from the contextual menu when right-clicking the extension toolbar icon
• by removing the extension and selecting to report it in the uninstall doorhanger, the removing process being triggered from the ”three dot” menu from the extension card, “three dot” menu from the extension detail page or from the contextual menu when right-clicking the extension toolbar icon

3. The “Report Abuse” window from themes does not appear to be affected by this.
4. Linux appears to have a larger “Report Abuse” window and the issue does not occur on this platform

[Expected results]:
The “Report Abuse” window should be properly displayed with no missing padding at the bottom.

[Actual results]:
Sometimes when reporting extensions, the “Report Abuse” window is missing padding at the bottom, causing the buttons to look cut-off.

For further details, see the attached screenshots (both screenshots are from Windows, one depicting the window with missing padding and the other one when the issue does not trigger i.e. proper display of the window).

Comment 1

[Alex Cornestean]

Attachment: Missing padding.png

Comment 2

[Alex Cornestean]

Attachment: Proper window.png

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

The dialog behavior is also depending from Operating System behavior and I recall that from time to time it the content size wasn't matching the window size as it should.

The button is still visible and accessible and so we agreed to set P5 and S4 on this issue.

As a side note on what we may look into to fix this issue:

• we may look into using the ResizeObserver instead of resize events (which if I recall correctly is what the panel is currently using to respond to the dialog window resizing while opening).
• it would actually be nice if we could move this panel into the same kind of in-browser panel where the printer dialogs and printer preview have been recently moved into (which may also be less subject to the kind of issue that slightly different OS behaviors can trigger).

Comment 4

[Ganna]

Attachment: Bug 1754401 - Extension Report Abuse window is intermittently missing padding at the bottom r=hjones

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16641e760ad2
Extension Report Abuse window is intermittently missing padding at the bottom r=hjones,extension-reviewers,robwu

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/16641e760ad2

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2022-02-09 Nightly build on Windows 10.
Verified as fixed on Firefox 117.0b5(build ID: 20230808215502) and Nightly 118.0a1(build ID: 20230809213044) on Windows 10, macOS 12, Ubuntu 22.
The “Report Abuse” window is properly displayed.