Stop updating `sources` in sources.js reducer when fetching text content of sources
Categories
(DevTools :: Debugger, task)
Tracking
(firefox100 fixed)
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 4 open bugs)
Details
Attachments
(3 files)
For now, we are mutation the source objects when we lazily fetch their source content.
This messes up with redux createSelector as it force updating the source object for which we fetched the source and also the sources object which list all available sources.
This forces us to add some more memoization in order to speed up selectors.
See https://phabricator.services.mozilla.com/D135620#4430442
In this bug, I mean to still host this data in sources.js reducer, but if relevant, we might move this data to its very own reducer (see bug 1541638).
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Comment 3•2 years ago
|
||
This replaces a jest test with some real usecases.
|
||
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/050226509387 [devtools] Only support ADD_SOURCES options. r=bomsy https://hg.mozilla.org/integration/autoland/rev/874b6b4c46b7 [devtools] Cover fetching source text content with a mochitest. r=bomsy https://hg.mozilla.org/integration/autoland/rev/dc8890682402 [devtools] Use a distinct reducer for source text content and make source objects immutables. r=perftest-reviewers,devtools-reviewers,bomsy,AlexandruIonescu
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/050226509387
https://hg.mozilla.org/mozilla-central/rev/874b6b4c46b7
https://hg.mozilla.org/mozilla-central/rev/dc8890682402
Description
•