1754416 - Better layout for the new Edit and Resend panel

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

The Headers section (list of HTTP headers) takes way too much space that necessary. See the attached screenshot (the top part) where you can compare with the "Response Headers" section in the Headers side panel. I think that height of the HTTP headers row could be smaller.

Also, when you make new Edit and Resend panel narrow, the layout seems to be broken entirely. See the attached screenshot (the bottom part). We should fix that, so it work for the minimum width limit.

Honza

Comment 1

[Hubert Boma Manilla (:bomsy)]

Thanks for reporting, Honza!

For narrow panel layout issue , we can probably add min-width: max-content; to the .tabpanel-summary-container http-custom-section class.

Caludia,
Maybe we can have a separate (quick) patch for that. WDYT?

Comment 2

[Claudia Batista [:claubatista]]

Attachment: Bug 1754416 - [devtools] Fix narrow panel layout r=bomsy

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23f9ff7daa01
[devtools] Fix narrow panel layout r=bomsy

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/23f9ff7daa01

Comment 5

[Ariel Shkedi]

I had to disable this because the new one only had a "Resend" button, rather than the old way which had both "Resend" and "Edit and Resend".

I also don't like that this doesn't reuse the location of the "Request Details" panel, instead it opens a third panel which takes up too much space.

Are you able to fix those two things?

Comment 6

[Julian Descottes [:jdescottes]]

(In reply to Ariel Shkedi from comment #5)

I had to disable this because the new one only had a "Resend" button, rather than the old way which had both "Resend" and "Edit and Resend".

I also don't like that this doesn't reuse the location of the "Request Details" panel, instead it opens a third panel which takes up too much space.

Are you able to fix those two things?

For the menu issue, this should be fixed at https://bugzilla.mozilla.org/show_bug.cgi?id=1777716, where we will go back to having 2 menu items: one to resend immediately, the other one to open the edit panel.

Regarding the second request, we can improve the experience with the "edit and resend" panel, but I don't think we can revert back to the Details Panel. Feel free to file other bugs if you have ideas or suggestions.