1754540 - Remove code that handles change requests as no longer needed

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Daniel Veditz [:dveditz]]

+++ This bug was initially created as a clone of Bug #1754486 +++

Bug 1754486 noticed found a link on an old server for employees to file requests with the now-gone mozilla.service-now.com service. A malicious person could claim that domain in service-now since we no longer use them, and then get potentially sensitive internal information (and maybe log in credentials?).

Turns out that very bug in bugzilla has the same problem. I don't know if it shows up elsewhere, but it's at least in the "Infrastructure & Operations" product.

STR

1. go to bug 1754486
2. Click the "Edit Bug" button at the top
3. Go to the "Details" section and look at the "Change Request" field

Actual result:
There's a ServiceNow Change Request to a server we don't own

Expected result:
one of

1. A link to the correct change-request system
2. no link at all
3. not even a "Change Request" field... use See Also to track related JIRA tickets?

I don't know if other products/components have similar links. The products I normally work with don't have a Change Request field.

Comment 1

[David Lawrence [:dkl]]

I have made the cf_cab_review custom field in BMO obsolete which is supposed to disable the field. In this case, it removes
the broken link (good) and the drop down values. But the field label and empty drop down still appear which will need to
be fixed. I will look at fixing the latter. But the link is gone which is good.

Comment 2

[Daniel Veditz [:dveditz]]

Thanks!

Comment 3

[Daniel Veditz [:dveditz]]

From my POV you can mark this FIXED, but if you want to leave it open to cover the other changes you want to do that's fine too

Comment 4

[David Lawrence [:dkl]]

(In reply to Daniel Veditz [:dveditz] from comment #3)

From my POV you can mark this FIXED, but if you want to leave it open to cover the other changes you want to do that's fine too

Comment 5

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 6

[David Lawrence [:dkl]]

Merged to master
https://github.com/mozilla-bteam/bmo/commit/810a972f04c168854ff5349bf257807fed2a7882