1754744 - Simplifying nsHttpConnection - isolating TLS handshake code

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P3)

Description

[Dragana Damjanovic [:dragana]]

nsHttpConnection drives TLS handshake. Currently, this is mixed in all the other code of nsHttpconnection. It would be good to try to isolate that code into a separate strucure. nsHttpConnection would benefit from some kind of state machine as well so that TLS handshake code and 0RTT code are easier to read.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1754744 - isolating TLS handshake code, r=#necko

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36943e34018f
isolating TLS handshake code, r=necko-reviewers,dragana

Comment 3

[Atila Butkovits]

Backed out for causing bustages at TlsHandshaker.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/ffe9c8c6097de888c1ad41865e7744dc8f675214

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=36943e34018f6bc2d13b35e015138b7661321553&selectedTaskRun=bj70ROW1QyefYKXuJDvelQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=372586662&repo=autoland&lineNumber=48749

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7b879827137
isolating TLS handshake code, r=necko-reviewers,dragana

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing build bustages on Unified_cpp_protocol_http4.obj

Backout link

Push with failures

Failure log

Failure line: gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:658: Unified_cpp_protocol_http4.obj] Error 1

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: fixup! Bug 1754744 - isolating TLS handshake code, r=#necko

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/926e2d800cbe
isolating TLS handshake code, r=necko-reviewers,dragana

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/926e2d800cbe