1754796 - Scrolling through the all tabs menu uses 100% of a core painting

Status: NEW

(Core :: Graphics, defect)

Description

[Florian Quèze [:florian]]

See this profile: https://share.firefox.dev/3BgiT9k

I was scrolling up and down through the all tabs menu in a window that had about 210 tabs.

This used a lot of CPU, and I think we skipped a few frames here and there.

Comment 1

[Markus Stange [:mstange]]

The all tabs menu uses fallback painting. We should switch it to using WebRender.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1754796 - Use WebRender for all popups except tooltips, so that scrolling is efficient. r=jrmuizel

This is especially important for popups which contain lists of tabs or lists of bookmarks.

Comment 3

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/jobs?repo=try&revision=84dc0942b0b179a203b995059f4606f1ac55fda3

Comment 4

[Markus Stange [:mstange]]

There are at least two test failures:

• The M-swr(gpu) job fails with "gfx/tests/mochitest/test_acceleration.html | Acceleration enabled on x86-64 OS X - didn't expect +0, but got it"
• The bc7 jobs crash in browser/components/extensions/test/browser/browser_ext_browserAction_popup.js when closing the popup, in MOZ_RELEASE_ASSERT(mWebRenderUserDatas.Count() == 0).

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:bhood, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mstange, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 7

[Markus Stange [:mstange]]

There's more work to be done, see comment 4.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

I'm downgrading this to S3 because I don't think anyone would stop using Firefox because of it.

Comment 9

[Markus Stange [:mstange]]

I'm not working on this at the moment, but I still think this is worth doing. Somebody would need to debug the test failures this caused.

Comment 10

[Timothy Nikkel (:tnikkel)]

When this lands the workaround from bug 1889166 that added a aFrame->HasAnyStateBits(NS_FRAME_IN_POPUP) check to InvalidateImages in layout/style/ImageLoader.cpp should be removed.

Comment 11

[Timothy Nikkel (:tnikkel)]

I updated the patch and pushed it to try
https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=02a88cda478b2e1cdbc71b2cd78baa22fd8e3191

Still failing a few tests, here is a clean push on the same revision to better tell apart orange caused by the patch versus already present

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=0a5a1652cb8f95cf757fe8f5e3bf110ff96a6004