1754887 - Rename downloads "Delete" context menu item to "Delete File"

Status: ASSIGNED

(Firefox :: Downloads Panel, enhancement, P2)

Description

[Shane Hughes [:aminomancer]]

Since bug 1750484, the "Delete" context menu item no longer deletes the selected download. This can be changed by pref, but by default, it only deletes the download's target file/part data, not the download itself. Because of that, the label "Delete" is kind of confusing and could be confused with the "Delete" menuitem in the #organizeButtonPopup in the places organizer. That menuitem has exactly the same label but the opposite function — that is, it doesn't delete the file, but it does delete the download.

In other words, we have 2 menuitems in slightly different places that both have the same label but they do opposite things. This also prevents us from adding the delete file command to the Organizer menu, since then we'd have 2 different menuitems in the same menu with the same label (see bug 1754885).

So, is it sensible to change the delete file menuitem's label to "Delete File"? I think those of us who were working on it have been calling it "the delete file menuitem" all along anyway haha. It's my mistake, I should have changed the label in bug 1750484 when we changed the default behavior to not remove the download.

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: Bug 1754887 - Rename downloads "Delete" context menu item.

The "Delete" context menu item no longer deletes the download by
default; it only deletes the download's file(s). So, rename it to
"Delete File" to make this clearer.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:aminomancer, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 4

[:Gijs (he/him)]

This is blocked on a decision about plurals for "Delete files" in bug 1754885.