Closed Bug 1754898 Opened 3 years ago Closed 3 years ago

Invitations link does not show when calendar is cached.

Categories

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

defect

Tracking

(thunderbird_esr91 unaffected)

RESOLVED FIXED
99 Branch
Tracking Status
thunderbird_esr91 --- unaffected

People

(Reporter: lasana, Assigned: lasana)

References

Details

Attachments

(1 file)

STR:

  1. Have a caldav calendar and enable offline support.
  2. Receive an event with a future date, open the email but do not take any actions.
  3. Wait for the server to add the event to your calendar.
  4. Either restart Thunderbird or wait for the invitations manager to refresh.

Expected Result: The Invitations: 1 link should appear in the status bar

Actual Result: It does not appear.

This is because of an error introduced in bug 1693873 treating regular items as occurrences.

Status: NEW → ASSIGNED

I'm not aware of this specific issue being a regression, removing keyword.

Keywords: regression
Attachment #9263509 - Attachment is obsolete: true

Seems like the link not showing was a symptom of a bigger problem:

Things work fine if you have just one account but you can ran into this issue if you add another with an associated calendar for it. Invitations for the first one will trigger the link but invitations on the second appears to be ignored. From my testing, seems like the wrong "invitedAttendee" is returned here:

https://searchfox.org/comm-central/rev/701c8968d78abc05cda262e3acb56991f1bfd9f7/calendar/providers/storage/CalStorageItemModel.jsm#316

I'm updating the title and steps to reproduce.

Edit:
Actually, I'm not sure that's what's taking place either because it does not happen consistently. Further investigation needed.

Keywords: regression
No longer regressed by: 1693873

Ok. This is indeed a problem introduced by bug 1693873 (or possibly uncovered by it). The original patch would have worked except it went a little too far. Just making the schedulingSupport property lazy so the correct superCalendar is used should suffice.

Regressions: 1693873
Attachment #9263509 - Attachment is obsolete: false
Attachment #9263509 - Attachment description: Bug 1754898 - Do not exclude events with partStat "NEEDS-ACTION", use correct calIScheduling support. r=darktrojan → Bug 1754898 - Make schedulingSupport property lazy in CalStorageItemModel. r=darktrojan
Target Milestone: --- → 99 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/611a52551948
Make schedulingSupport property lazy in CalStorageItemModel. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: