Closed
Bug 1754930
Opened 3 years ago
Closed 3 years ago
Make check_macroassembler_style understand mozilla::Maybe
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
99 Branch
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: lth, Assigned: lth)
References
Details
Attachments
(1 file)
The syntax for parsing types optional args is a bit limited and can't handle mozilla::Maybe; expand it.
|
Assignee | |
Comment 1•3 years ago
|
||
Basically, argument types must allow for templated types and optional args must
recognize at least mozilla::Nothing(). It's a bit hacky but it seems like
a useful extension that won't destroy anything, and I need this.
Depends on D138052
|
|
Assignee | |
Updated•3 years ago
|
Severity: -- → N/A
Priority: -- → P3
|
||
Updated•3 years ago
|
Attachment #9263451 -
Attachment description: Bug 1754930 - understand Nothing. r?nbp → Bug 1754930 - Understand Nothing. r?nbp
|
|
||
Updated•3 years ago
|
Attachment #9263451 -
Attachment description: Bug 1754930 - Understand Nothing. r?nbp → Bug 1754930 - Understand mozilla::Maybe in masm declarations. r?nbp
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1feee3d48d1
Understand mozilla::Maybe in masm declarations. r=nbp
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox99:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•