1754945 - uBlock Origin window is slow and some icons are blurry

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[bloonyapprentice]

Attachment: BlurryIcons.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0

Steps to reproduce:

1. Go to about:profiles and create a new profile.
2. Install uBlock Origin.
3. Click on uBlock Origin icon.
4. You might have to click "More" to show more parts of the window.

Actual results:

uBlock's window fades in slowly and stuttery. When I try to hover around the columns on the left, the response are delayed. The "Block all popups" and "Block remote fonts" icons are blurry as well.

Expected results:

uBlock's window should be quick and responsive like before. The icons should be clear.

Comment 1

[bloonyapprentice]

Attachment: Here's mozregression log.

```

Comment 2

[bloonyapprentice]

Attachment: before.mp4

Performance before the bug:

Comment 3

[bloonyapprentice]

Attachment: after.mp4

Performance after the bug:

Comment 4

[nayinain]

Attachment: Capture.webm

I can reproduce this issue. There is a big lag in the state change when the mouse hovers over the uBlock popup window within 10 seconds after opening it.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1749380

Comment 6

[Mayank Bansal]

https://share.firefox.dev/3LwYe5l

Comment 7

[Glenn Watson [:gw]]

Would you be able to share the content of your about:support here? While there is definitely a bug from that patch (and I'll look in to it today), it would also be good to find out why your system is running software-webrender, and see if it's possible to get you running hardware accelerated webrender.

Comment 8

[Lee Salzman [:lsalzman]]

(In reply to Glenn Watson [:gw] from comment #7)

Would you be able to share the content of your about:support here? While there is definitely a bug from that patch (and I'll look in to it today), it would also be good to find out why your system is running software-webrender, and see if it's possible to get you running hardware accelerated webrender.

Aren't popup windows often SW-WR by default now?

Comment 9

[Glenn Watson [:gw]]

(In reply to Lee Salzman [:lsalzman] from comment #8)

(In reply to Glenn Watson [:gw] from comment #7)

Would you be able to share the content of your about:support here? While there is definitely a bug from that patch (and I'll look in to it today), it would also be good to find out why your system is running software-webrender, and see if it's possible to get you running hardware accelerated webrender.

Aren't popup windows often SW-WR by default now?

Ah, you're probably right - that would indeed explain it.

Comment 10

[Glenn Watson [:gw]]

The patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1754809 seems to fix the blurriness for me here. I didn't notice any slowdown, but it's plausible that this snapping fix might help with that too - once we get it merged (if a try run is clean) let's see if it affects blurriness and/or performance for OP here.

Comment 11

[bloonyapprentice]

Attachment: about:support

Here's my about:support in a new profile.

Comment 12

[Pulse]

Attachment: support.txt

Thought I'd mention this is also happening on Linux. Not only does the uBO window lag when opening, in Advance User mode there is noticeable lag when hovering over individual rule cells.

openSUSE Tumbleweed 20220210
Plasma 5.24
uBO 1.41.2
Nightly 20220214092817

Comment 13

[bloonyapprentice]

I see that the patch has been merged in bug 1754809, but it happened around the same time when Nightly just received a new update (Build ID 20220214213941). I suppose the patch isn't available in this build yet?

Comment 14

[Glenn Watson [:gw]]

Not yet - the patch has been pushed and is on autoland - it sometimes takes ~12 hours or so between a patch being pushed, then landing in m-c, then making it in to the next nightly build. However, if you're interested in testing locally before then, I can point you to build artifacts from a try run that you can download and test out?

Comment 15

[bloonyapprentice]

(In reply to Glenn Watson [:gw] from comment #14)

if you're interested in testing locally before then, I can point you to build artifacts from a try run that you can download and test out?

Yes please, in case there are additional fixes needed.

Comment 16

[Glenn Watson [:gw]]

https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/R0Ohk5yoRU2VNlaeQZWowQ/runs/0/artifacts/public/build/target.zip is a windows build from the try run https://treeherder.mozilla.org/jobs?repo=try&revision=7cf8cfbde59f75a7db11fe1a6b15ad47a8dc33eb&selectedTaskRun=R0Ohk5yoRU2VNlaeQZWowQ.0

Comment 17

[Mayank Bansal]

(In reply to Glenn Watson [:gw] from comment #16)

https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/R0Ohk5yoRU2VNlaeQZWowQ/runs/0/artifacts/public/build/target.zip is a windows build from the try run https://treeherder.mozilla.org/jobs?repo=try&revision=7cf8cfbde59f75a7db11fe1a6b15ad47a8dc33eb&selectedTaskRun=R0Ohk5yoRU2VNlaeQZWowQ.0

The try build didnt fix the slow pop-up of the uBlock menu. (this could be bug 1754685 though)

Comment 18

[bloonyapprentice]

Yep, this didn't seem to fix anything. Not even the blurriness mentioned in comment 10.

Comment 19

[Glenn Watson [:gw]]

Huh, it fixes it locally for me (tested on a Linux machine only though). There does seem to be something else weird going on specifically with that uBO popup though, as it gets scale factors in the transform matrices of 0.98, which is unexpected. Still investigating for this case.

Comment 20

[Glenn Watson [:gw]]

Fixed by backout. I will be re-landing this patch series next week, with changes that fix this issue. Please re-open if it occurs again.

Comment 21

[Giorgia Nichita, Release Desktop QA]

I've reproduced this issue on an affected nightly build (2022-02-11) on Windows 10 x64.

Verified as fixed on Firefox 99.0b7 (20220322185926) on Windows 10 x64, Ubuntu 20.04 and macOS 10.15.