Closed
Bug 1754981
Opened 2 years ago
Closed 2 years ago
[wdspec] BiDi tests should use "asyncio.sleep()" and not "time.sleep() which blocks
Categories
(Testing :: geckodriver, defect, P2)
Testing
geckodriver
Tracking
(firefox99 fixed)
RESOLVED
FIXED
99 Branch
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
Details
(Whiteboard: [bidi-m3-mvp], [wptsync upstream])
Attachments
(1 file)
Julian noticed that when reviewing my code for bug 1694389.
Using time.sleep() will block and not allow the tests to handle incoming events. As such tests don't really test what we expect them to test.
Instead await asyncio.sleep() should be used. Affected tests here are for log.entryAdded.
|
Assignee | |
Updated•2 years ago
|
Points: --- → 1
Priority: -- → P2
|
|
Assignee | |
Updated•2 years ago
|
Severity: -- → S3
|
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•2 years ago
|
||
Depends on D138996
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ecab2a7d150f [wdspec] Use "asyncio.sleep()" and not "time.sleep() which blocks. r=webdriver-reviewers,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32870 for changes under testing/web-platform/tests
Whiteboard: [bidi-m3-mvp] → [bidi-m3-mvp], [wptsync upstream]
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox99:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in
before you can comment on or make changes to this bug.
Description
•