1755008 - The buttons from the Add New Address modal are not centered on the DE locale

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P3)

Description

[Simona Badau, Desktop QA]

Affected Versions:

Nightly 99.a1, Beta 98 and Release 97

Tested on:

MacOS 11

Preconditions:

browser.search.region DE
extensions.formautofill.addresses.enabled - true
extensions.formautofill.addresses.supported to "detect"
extensions.formautofill.addresses.supportedCountries US,CA,DE

download and install the latest Firefox Nightly DE locale

Steps to reproduce:

1. Go to about:preferences#privacy
2. In the Forms and Autofill section, click the Saved Addresses button.
3. In the Saved Addresses modal, click on the Add button.
4. Observe the Cancel (Abbrechen) and Save (Enregistrer) buttons.

Expected Results:

All the buttons are properly displayed.

Actual Results:

The Cancel (Abbrechen) and Save (Enregistrer) buttons are not centered.

Comment 1

[Simona Badau, Desktop QA]

Attachment: Screenshot with the issue

Comment 2

[gliu20]

Hi I'm new to contributing to Firefox and I'd like to take this issue. It seems like the cause of this issue is the same as https://bugzilla.mozilla.org/show_bug.cgi?id=1754999. I can confirm that the root cause of this issue is caused by the #country-warning-message forcing buttons with a sufficiently large size to be cut off. Allowing #country-warning-message to dynamically resize fixes this.

I already see that the css for this is in editAddress.css and if no one else plans to take this issue, I'll get started with Phabricator and submit a patch.

Comment 3

[gliu20]

Attachment: Bug 1755008 - Fix cut off buttons styling from Add New Address modal. r?#preferences,sfoster

Fixes the Add New Address modal buttons getting clipped in certain locales.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6c17b233f15
Fix cut off buttons styling from Add New Address modal. r=tgiles

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c6c17b233f15

Comment 7

[Gabi Cheta [:Gabi] Desktop QA]

Reproduced the issue with Fx 99.0a1 (2022-02-11) on Windows 10x64.
Verified as fixed with Fx 101.0a1 and Fx 100.0b Windows 10x64, Ubuntu 18.4 and macOS 10.12.6 de and fr locales.