1755040 - [wpt-sync] Sync PR 32818 - [tables] Fix producing negative columns.

Status: RESOLVED FIXED

(Core :: Layout: Tables, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32818 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32818
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[tables] Fix producing negative columns.

Previously we were using float logic within
DistributeInlineSizeToComputedInlineSizeAuto.

This had the effect (when pushed to extremes) to produce negative
column widths, which would result in a negative available space
given to some children.

This negative available space will cause some layouts (block) to do
bad things like try and do a null-deref read.

This patch changes the logic to keep everything in the LayoutUnit
space.

Bug: 1294634
Change-Id: Ic86cb54620bd1985024d60b7510c7281e6799ebf

Reviewed-on: https://chromium-review.googlesource.com/3451134
WPT-Export-Revision: 529abce5baa0e7c3d9e01ca8fb2e75d47688ddf6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7420ef66ca7dcacad770034181c18d81cc5c537

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db4b7a912b7f
[wpt PR 32818] - [tables] Fix producing negative columns., a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3319920cc939
[wpt PR 32818] - [tables] Fix producing negative columns., a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3319920cc939