175515 - Bookmarks Toolbar Icons are corrupt

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Tobias Tinkerman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021019 Phoenix/0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021019 Phoenix/0.3

Since the 10-18 build, icons in the Bookmarks Toolbar seem shrunk/corrupt -
especially the default bookmark icon.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Asa Dotzler [:asa]]

confired. I see this on linux. It looks like they're being scaled down a pixel
or two. 

Comment 2

[Sébastien Delahaye]

Attachment: Patch

Here's the patch to fix this. The bug was caused by this commit:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/browser/base/skin&command=DIFF_FRAMESET&file=browser.css&rev1=1.64&rev2=1.65&root=/cvsroot


As a temporary workaround, you can add the following css to your
userChrome.css:

toolbar[mode="icons"] .toolbarbutton-icon {
  padding: 0px 0px 0px 0px !important;
}

Comment 3

[David Hyatt]

Fixed.

Comment 4

[Michael Brutsch]

Many thanks; as far as I can tell, the preceding workaround performs
wonderfully, at least for all the sites I bookmark, save one: www.kuro5hin.org.
 It appears that most sites use a 16x16 favicon; kuro5hin uses a 32x32 icon. 
The icon renders perfectly in a Tab; when it is scaled for the Toolbar, and for
the 'Bookmarks' menu item, it retains the '1 or 2 pixel' scrunchy problem; and
in the 'Bookmarks' sidebar, it is cropped to the upper-left quadrant, giving a
'quarter-round' image.

Comment 5

[Brant Gurganus]

VERIFIED Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030714
Mozilla Firebird/0.6