1755226 - check if there are any "http-on-image-cache-response" observers in imgLoader::NotifyObserversForCachedImage before doing any work

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, enhancement)

Description

[Timothy Nikkel (:tnikkel)]

Attachment: imgc.html

(You need to provide a local file white.png for the testcase, I used a small image I had handy)

With the attached testcase I compared current behaviour vs commenting out the call to NotifyObserversForCachedImage.

Current behaviour was about 290ms, commenting out NotifyObserversForCachedImage was about 180ms.

So it seems worth it to optimize.

Comment 1

[Sean Feng [:sefeng]]

Attachment: Bug 1755226 - Only notify 'http-on-image-cache-response' when there are registered observers r=tnikkel

This is an optimization to avoid doing redundant things when there are no
registered observers.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/480ba71887c8
Only notify 'http-on-image-cache-response' when there are registered observers r=tnikkel

Comment 3

[Atila Butkovits]

Backed out for causing build bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/de0915875736250d12daab0e17c5a243d49042e0

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=480ba71887c820760fa42f50f6d66e71d3792125

Failure log:
-https://treeherder.mozilla.org/logviewer?job_id=368110187&repo=autoland&lineNumber=13386
-https://treeherder.mozilla.org/logviewer?job_id=368120411&repo=autoland&lineNumber=2714

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccf8fba00ca0
Only notify 'http-on-image-cache-response' when there are registered observers r=tnikkel,emilio

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ccf8fba00ca0