1755297 - ESLint incorrectly assumes `structuredClone` is available everywhere

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P2)

Description

[Mark Banner (:standard8)]

ESLint incorrectly assumes that structuredClone is available everywhere. According to @evilpie it is only available in:

Anything that uses WindowOrWorkerGlobalScope plus Sandbox

We should change the definition to at least only be available in browser-window & frame scopes rather than globally. That may be a bit restrictive (i.e. not all window spaces), but until it gets added to ESLint's globals, that'll probably be better than what we have now.

Whilst we're here we should also remove these no-undef exclusions:

https://searchfox.org/mozilla-central/rev/e66593593f3b356901011ea0fcdf9979728e9ae8/uriloader/exthandler/tests/mochitest/browser_download_preferred_action.js#276-277,285,293

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1755297 - Match ESLint's definition of structuredClone to where it is actually defined. r?Gijs!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug is a defect, but please change it back in case of error.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1745030

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d4262b94d3a
Match ESLint's definition of structuredClone to where it is actually defined. r=Gijs

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8d4262b94d3a