1755375 - GPU process kills are registered as crashes.

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, defect)

Description

[[ex-Mozilla] Agi Sferro | :agi]

When the GPU process is killed by the OS, we should not start the crashreporter.

You can reproduce this by calling adb shell kill -9 <gpu process PID> when the browser is in the background.

Comment 1

[Jamie Nicol [:jnicol]]

Attachment: Bug 1755375 - Don't generate crash reports when android kills the GPU process. r?agi

If the android system kills the GPU process then ChildCrashHandler.jsm
gets invoked but an empty dump ID. Currently we generate a crash
report anyway, which is resulting in lots of "EMPTY: no crashing
thread identified; ERROR_NO_MINIDUMP_HEADER" crashes.

Instead, we should return early before starting the crash reporter if
the dump ID is empty. We already do this for content processes, so
this patch makes us do so for every type of process.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fae6a6b254a
Don't generate crash reports when android kills the GPU process. r=agi

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0fae6a6b254a

Comment 4

[Chris Peterson [:cpeterson]]

Moving GPU process bugs to the new GeckoView::Sandboxing component.