1755385 - Drop non-content process priority to IDLE when going to the background

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, defect)

Description

[[ex-Mozilla] Agi Sferro | :agi]

The GPU process is really cheap to restart and restarting it doesn't have side effects, so we should prioritize it lower than harder-to-restart processes like content processes when we're not actively running in foreground.

Comment 1

[Jamie Nicol [:jnicol]]

Is this already taken care of here, or is there additional work to do? Or do we want an even lower priority for the GPU process?

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Oh interesting! I think we should just change that to IDLE then. I think we didn't fully understand the meaning of those values back when the code was written.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1755385 - Drop non-content process priority to IDLE when backgrounding.

BACKGROUND and FOREGROUND priority lead to the identical oom_adj value of 11
when the app is in the background. Because all non-content processes are
restartable without losing any state, we should prioritize them lower than the
current active tab, which will be prioritized to FOREGROUND when Bug 1753700 is
fixed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccc93601eab2
Drop non-content process priority to IDLE when backgrounding. r=jonalmeida

Comment 5

[Cathy Lu [:calu]]

Do you know how the BACKGROUND and FOREGROUND priority lead[s] to the identical oom_adj value of 11, where it gets calculated or is that calculated by the Android OS?

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

I'm not sure yet, but this doc seems interesting: https://cs.android.com/android/platform/superproject/+/master:frameworks/base/services/core/java/com/android/server/am/OomAdjuster.md

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ccc93601eab2

Comment 8

[Chris Peterson [:cpeterson]]

Moving content process management bugs to the new GeckoView::Sandboxing component.