1755441 - Webrender blocked on nvidia 470.103.01

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Jamie Nicol [:jnicol]]

+++ This bug was initially created as a clone of Bug #1754685 +++
The user in bug 1754685 found they had been moved from hardware webrender to software webrender as a result of bug 1742994. This bumped the minimum required nvidia driver version to 470.82.0. However, the user has 470.103.01 which I would have thought was more recent.

Is this a bug in our blocklisting logic? Or is 103 really older than 82?

Comment 1

[Jamie Nicol [:jnicol]]

Attachment: about:support

about:support copied from bug 1754685

Comment 2

[Jamie Nicol [:jnicol]]

I'm sure I needinfo'd you both when filing the bug, but apparently not :shrug:

Comment 3

[Robert Mader [:rmader]]

(In reply to Jamie Nicol [:jnicol] from comment #0)

Is this a bug in our blocklisting logic? Or is 103 really older than 82?

That's either a bug in the logic or I messed up and it should have been 470.082.0 :)

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1742994

Comment 6

[Darkspirit]

https://searchfox.org/mozilla-central/search?q=DeviceFamily%3A%3ANvidiaAll&path=GfxInfo.cpp&case=false&regexp=false

There are two WEBRENDER entries for proprietary Nvidia (which seems expected),

• FEATURE_BLOCKED_DEVICE
• FEATURE_ALLOW_QUALIFIED, but non-Nvidia ALLOWLIST entries are instead FEATURE_ALLOW_ALWAYS.

Comment 7

[Darkspirit]

FEATURE_BLOCKED_DEVICE also has incorrect 460.32.03, it should be 470.82.0.

Comment 8

[Andrew Osmond [:aosmond] (he/him)]

There are a bunch of related entries, so it isn't that easy to discern right away:

Block WebRender < 460.32.3 because old drivers:
https://searchfox.org/mozilla-central/rev/94d7c959115c03ea1e9406d6105b36cabe63775d/widget/gtk/GfxInfo.cpp#709

Allow WebRender >= 470.82.0 because new enough:
https://searchfox.org/mozilla-central/rev/94d7c959115c03ea1e9406d6105b36cabe63775d/widget/gtk/GfxInfo.cpp#794

Block X11 EGL < 470.82.0:
https://searchfox.org/mozilla-central/rev/94d7c959115c03ea1e9406d6105b36cabe63775d/widget/gtk/GfxInfo.cpp#826

Block DMABuf < 495.44.0:
https://searchfox.org/mozilla-central/rev/94d7c959115c03ea1e9406d6105b36cabe63775d/widget/gtk/GfxInfo.cpp#843

We are supposed to pad out the driver versions if < 1000:
https://searchfox.org/mozilla-central/rev/94d7c959115c03ea1e9406d6105b36cabe63775d/widget/GfxDriverInfo.h#399

It appears it pads out the other way though, so 82 becomes 8200. Presumably that means 102 becomes 1020 and it gets blocked.

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

We should probably have a different version of that version macro for Linux (and other platforms?).

Comment 10

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1755441 - Stop padding driver versions on platforms other than Windows.

Windows has different driver version semantics than other platforms. We
shouldn't pad the driver versions the same way on Linux/OSX/Android for
our blocklist rules and instead just take the numbers as given. This
really only impacted Linux since it had numerous blocklist rules which
depending on the vendor or Mesa driver versions.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/563472b3bac1
Stop padding driver versions on platforms other than Windows. r=jrmuizel

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/563472b3bac1

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:aosmond, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 14

[Andrew Osmond [:aosmond] (he/him)]

Are you willing to verify this for me so I can request uplift? :)

Comment 15

[Pascal Chevrel:pascalc]

Tracking for a potential uplift (we build our last beta tomorrow).

Comment 16

[Darkspirit]

Gnome X11, Ubuntu 22.04 jammy, GTX 1060

Comparing:

• nvidia-driver-470 470.86-0ubuntu2
• nvidia-driver-470 470.103.01-0ubuntu1 from deb http://de.archive.ubuntu.com/ubuntu/ jammy-proposed restricted
• nvidia-driver-495 495.46-0ubuntu3
• nvidia-driver-510-server 510.47.03-0ubuntu1

mozregression --launch 2022-02-15 -a about:support

• Driver Version: 470.86.0.0, WebGL 2 Driver Version: 3.2.0 NVIDIA 470.86: WR, EGL
• Driver Version: 470.103.1.0 vs. WebGL 2 Driver Version: 3.2.0 NVIDIA 470.103.01: SW WR, GLX
• Driver Version: 495.46.0.0, WebGL 2 Driver Version: 3.2.0 NVIDIA 495.46: WR, EGL
• Driver Version: 510.47.3.0 vs. WebGL 2 Driver Version: 3.2.0 NVIDIA 510.47.03: WR, EGL

mozregression --launch 2022-02-18 -a about:support

• Driver Version: 470.86.0.0, WebGL 2 Driver Version: 3.2.0 NVIDIA 470.86: WR, EGL
• Driver Version: 470.103.1.0 vs. WebGL 2 Driver Version: 3.2.0 NVIDIA 470.103.01: WR, EGL
• Driver Version: 495.46.0.0, WebGL 2 Driver Version: 3.2.0 NVIDIA 495.46: WR, EGL
• Driver Version: 510.47.3.0 vs. WebGL 2 Driver Version: 3.2.0 NVIDIA 510.47.03: WR, EGL

Comment 17

[Andrew Osmond [:aosmond] (he/him)]

Perfect, thank you very much Darkspirit! :)

Comment 18

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9264175 [details]
Bug 1755441 - Stop padding driver versions on platforms other than Windows.

Beta/Release Uplift Approval Request

• User impact if declined: What graphics features are blocked on Linux will be somewhat unpredictable because of the driver version comparison mismatch
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It is partly covered by automated tests. Our blocking is already sort of random on Linux.
• String changes made/needed:

Comment 19

[Pascal Chevrel:pascalc]

Comment on attachment 9264175 [details]
Bug 1755441 - Stop padding driver versions on platforms other than Windows.

Approved for out last 98 beta, thanks.

Comment 20

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/1615e75e0f46