1755523 - fix signature generation so it doesn't use raw crash data

Status: RESOLVED FIXED

(Socorro :: Signature, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Signature generation is a pipeline of rules that look at various parts of crash data to compose a signature. Most of the data it looks at comes from processed crash data which is normalized and validated by rules in the processor pipeline. However, it also looks at raw crash data which is whatever the crash reporter sent in the crash annotation values.

We shouldn't do that. Signature generation should only use data that's been normalized and validated.

As of this writing, we need to switch the following fields:

• AbortMessage
• OOMAllocationSize
• ipc_channel_error
• IPCMessageName
• additional_minidumps

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6013: bug 1755523: end raw crash use in signature generation

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6013: "bug 1755523: end raw crash use in signature generation" in ca9d65f.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

That covers the last field (additional_minidumps). I did the rest in https://github.com/mozilla-services/socorro/pull/6008 .

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I deployed this to prod just now in bug #1759160. Marking as FIXED.