Closed Bug 1755523 Opened 1 year ago Closed 11 months ago

fix signature generation so it doesn't use raw crash data

Categories

(Socorro :: Signature, task, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

Attachments

(1 file)

Signature generation is a pipeline of rules that look at various parts of crash data to compose a signature. Most of the data it looks at comes from processed crash data which is normalized and validated by rules in the processor pipeline. However, it also looks at raw crash data which is whatever the crash reporter sent in the crash annotation values.

We shouldn't do that. Signature generation should only use data that's been normalized and validated.

As of this writing, we need to switch the following fields:

  • AbortMessage
  • OOMAllocationSize
  • ipc_channel_error
  • IPCMessageName
  • additional_minidumps
Assignee: nobody → willkg
Status: NEW → ASSIGNED

That covers the last field (additional_minidumps). I did the rest in https://github.com/mozilla-services/socorro/pull/6008 .

I deployed this to prod just now in bug #1759160. Marking as FIXED.

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.