1755550 - Fix strict warning for SeaMonkey startup when checking mail and news defaults.

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Backend, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

+++ This bug was initially created as a clone of Bug #1475867 +++

Bug 1475867 changed only the suite internal usage of nsIShellService but missed the reference in mailnews.
Given that the dialog is only defined in SeaMonkey make the implementation suite only. The affected code is no longer usable/called in comm-central because the accountUtils code was unfortunately made "tab only" and unusable in bug 1697575 so this is for 2.53 and 2.57 only right now until we have forked and restored the original functionality.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1755550-fixdefaultclient-25312.patch

For 2.53.x and 2.57 only.
[Approval Request Comment]
Regression caused by (bug #): Bug 1063529
User impact if declined: current default setting not checked right during startup
Testing completed (on m-c, etc.): 2.53.12b1 pre
Risk to taking this patch (and alternatives if risky): broken already.
String changes made by this patch: --

Comment 2

[Ian Neal]

Comment on attachment 9264045 [details] [diff] [review]
1755550-fixdefaultclient-25312.patch

>+++ b/mailnews/base/prefs/content/accountUtils.js
>+    // the default for mail/news and are not the default client for mail/news.
>+    if (appTypesCheck &&  ShellService.shouldCheckDefaultClient &&
Nit: only need a single space here
>+        ! ShellService.isDefaultClient(true, appTypesCheck))
Nit: no space needed between ! and S

r/a = me with those fixed.

Comment 3

[Frank-Rainer Grahl (:frg)]

2.53.12+ only at the moment:
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/71bea9b2108dea26aacb73f21f684d43b73df08c
Use ShellService.jsm for checking default client. r=IanN a=IanN