1755594 - Add NS_IMPL_CYCLE_COLLECTION_WITH_JS_MEMBERS

Status: RESOLVED FIXED

(Core :: DOM: Streams, task)

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1755594 - Part 2: Apply NS_IMPL_CYCLE_COLLECTION_WITH_JS_MEMBERS to dom/streams/ r=mgaudet

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1755594 - Part 1: Add NS_IMPL_CYCLE_COLLECTION_WITH_JS_MEMBERS r=mccr8!,smaug!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b347a6be8478
Part 1: Add NS_IMPL_CYCLE_COLLECTION_WITH_JS_MEMBERS r=mccr8,smaug
https://hg.mozilla.org/integration/autoland/rev/82a58b494f74
Part 2: Apply NS_IMPL_CYCLE_COLLECTION_WITH_JS_MEMBERS to dom/streams/ r=mgaudet,smaug

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bp-hybrid bustage on TeeState.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/56e0a1e5b84b080bb33f9bcf0d3f78a64ae630f4
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=797882f5e83f572fe7428909e1371248d106ec51
• failure log: https://treeherder.mozilla.org/logviewer?job_id=368871761&repo=autoland&lineNumber=20682

[task 2022-02-23T02:22:37.512Z] 02:22:37     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/MacOSX10.12.sdk -mmacosx-version-min=10.12 -stdlib=libc++ -std=gnu++17 --target=x86_64-apple-darwin -o TeeState.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/streams -I/builds/worker/workspace/obj-build/dom/streams -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing  -MD -MP -MF .deps/TeeState.o.pp   /builds/worker/checkouts/gecko/dom/streams/TeeState.cpp
[task 2022-02-23T02:22:37.513Z] 02:22:37    ERROR -  /builds/worker/checkouts/gecko/dom/streams/TeeState.cpp:17:1: error: no matching function for call to 'ImplCycleCollectionUnlink'
[task 2022-02-23T02:22:37.513Z] 02:22:37     INFO -  NS_IMPL_CYCLE_COLLECTION_WITH_JS_MEMBERS(TeeState,
[task 2022-02-23T02:22:37.514Z] 02:22:37     INFO -  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-02-23T02:22:37.514Z] 02:22:37     INFO -  /builds/worker/workspace/obj-build/dist/include/nsCycleCollectionParticipant.h:1063:5: note: expanded from macro 'NS_IMPL_CYCLE_COLLECTION_WITH_JS_MEMBERS'
[task 2022-02-23T02:22:37.514Z] 02:22:37     INFO -      NS_IMPL_CYCLE_COLLECTION_UNLINK(MOZ_FOR_EACH_EXPAND_HELPER js_members_) \
[task 2022-02-23T02:22:37.514Z] 02:22:37     INFO -      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-02-23T02:22:37.514Z] 02:22:37     INFO -  /builds/worker/workspace/obj-build/dist/include/nsCycleCollectionParticipant.h:541:16: note: expanded from macro 'NS_IMPL_CYCLE_COLLECTION_UNLINK'
[task 2022-02-23T02:22:37.514Z] 02:22:37     INFO -    MOZ_FOR_EACH(NS_IMPL_CYCLE_COLLECTION_UNLINK_HELPER, (), (__VA_ARGS__))
[task 2022-02-23T02:22:37.514Z] 02:22:37     INFO -    ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-02-23T02:22:37.514Z] 02:22:37     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/MacroForEach.h:62:26: note: expanded from macro 'MOZ_FOR_EACH'
[task 2022-02-23T02:22:37.514Z] 02:22:37     INFO -    MOZ_FOR_EACH_SEPARATED(aMacro, (), aFixedArgs, aArgs)
[task 2022-02-23T02:22:37.514Z] 02:22:37     INFO -    ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-02-23T02:22:37.514Z] 02:22:37     INFO -  note: (skipping 3 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
[task 2022-02-23T02:22:37.514Z] 02:22:37     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/MacroForEach.h:67:7: note: expanded from macro 'MOZ_FOR_EACH_HELPER'
[task 2022-02-23T02:22:37.515Z] 02:22:37     INFO -        aMacro, (MOZ_FOR_EACH_EXPAND_HELPER aFixedArgs MOZ_ARG_1 aArgs))
[task 2022-02-23T02:22:37.515Z] 02:22:37     INFO -        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-02-23T02:22:37.515Z] 02:22:37     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/MacroForEach.h:64:40: note: expanded from macro 'MOZ_FOR_EACH_HELPER_GLUE'
[task 2022-02-23T02:22:37.515Z] 02:22:37     INFO -  #define MOZ_FOR_EACH_HELPER_GLUE(a, b) a b
[task 2022-02-23T02:22:37.515Z] 02:22:37     INFO -                                         ^~~

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ea981dec8e0
Part 1: Add NS_IMPL_CYCLE_COLLECTION_WITH_JS_MEMBERS r=mccr8,smaug
https://hg.mozilla.org/integration/autoland/rev/4397efe72edb
Part 2: Apply NS_IMPL_CYCLE_COLLECTION_WITH_JS_MEMBERS to dom/streams/ r=mgaudet,smaug

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/9ea981dec8e0
https://hg.mozilla.org/mozilla-central/rev/4397efe72edb