1755598 - wpt runner doesn't restore prefs set in .ini files

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: wpt-pref-tests

For wpt reftests, we explicitly set apz.allow_zooming to false. If a wpt reftest sets apz.allow_zooming to true, then subsequenst reftests run with the pref is true for some reasons.

Attaching file a patch to add two wpt reftests demonstrating this issue.

Comment 1

[James Graham [:jgraham]]

Thanks, this testcase was useful. It seems like we're always clearing the pref value instead of restoring the previous value, because the pref reading function is incorrectly returning None for all pref values. I've got a patch, but need to run it through try since it will presumably affect some test results.

Comment 2

[James Graham [:jgraham]]

Attachment: Bug 1755598 - Fix restoring wpt pref values,

Previously we were always returning None from the pref getter, so we'd
only clear the pref value rather than restoring the previous value.

Comment 3

[James Graham [:jgraham]]

Attachment: Bug 1755598 - Test for setting and restoring pref values,

Based on a testcase by [e-mail]

Comment 4

[James Graham [:jgraham]]

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=OsXIGo1zTKS2FTI6CR7-xQ.0&revision=8463feedeec3ea82f20a340b4d90e1af7a4074c2 is a try run here. Surprisingly I don't see many test status changes, but it does seem to pass the tests that hiro wrote.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/737f6ccbbe11
Fix restoring wpt pref values, r=whimboo
https://hg.mozilla.org/integration/autoland/rev/5573d3d3f9e8
Test for setting and restoring pref values, r=whimboo

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32991 for changes under testing/web-platform/tests

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/737f6ccbbe11
https://hg.mozilla.org/mozilla-central/rev/5573d3d3f9e8

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot