1755660 - Proxy testing: Testing connection to origin servers via a proxy

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P3)

Description

[Dragana Damjanovic [:dragana]]

• An HTTP request with responses: 200, 404.
• An HTTP request with a redirect
• 2 HTTP requests to the same origin over an HTTP/2 proxy.
  Check that the proxy connection is reused.
• 2 HTTP requests to the same origin over an HTTP/2 proxy. One of the requests uses the anonymous flag.
  Check that the proxy connection is not reused.
• 2 HTTP requests to the same origin over an HTTP/2 proxy with a different triggering principal.
  Check that the proxy connection is not reused.
• A connection to the proxy fails with a non-authentication failure. (test at least 2 HTTP requests).
• Test a long post and check progress notifications as well.
• Test a post with a slower writer.
• Test a long response.
• Test a slove response reader.
• Test canceling an HTTP request:
  • as soon as the nsHttpChannel is open and a connection to the proxy does not exist already,
  • as soon as the nsHttpChannel is open and a connection to the proxy exists (only HTTP/2 proxy),
  • after the request is sent but before the response is received
  • while receiving a response.
    For the above tests check that the HTTP/2 connection to the proxy is not closed.
• Network connection breaks with different errors in different stages of a request and proxy setup.

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: Bug 1755660 - Add tests for testing HTTP/2 to the origin server through a HTTP/2 proxy, r=#necko

Comment 2

[Dragana Damjanovic [:dragana]]

Attachment: NS_HTTP_DISALLOW_SPDY should only affect the connection to the origin server.

Also AltSvc is disabled for HTTP proxies - addapt the test.

Comment 3

[Dragana Damjanovic [:dragana]]

Attachment: Bug 1755660 - Test progress notification with and without proxy

Comment 4

[Dragana Damjanovic [:dragana]]

The following tests should be covered with currently submitted patches or already existing tests:

• [x] An HTTP request with responses: 200, 404.
• [ ] An HTTP request with a redirect
• [x] 2 HTTP requests to the same origin over an HTTP/2 proxy.
  Check that the proxy connection is reused.
• [x] 2 HTTP requests to the same origin over an HTTP/2 proxy. One of the requests uses the anonymous flag.
  Check that the proxy connection is not reused.
• [x] 2 HTTP requests to the same origin over an HTTP/2 proxy with a different triggering principal.
  Check that the proxy connection is not reused.
• [x] A connection to the proxy fails with a non-authentication failure. (test at least 2 HTTP requests).
• [partially, only for HTTP2 server] Test a long post and check progress notifications as well.
• [ ] Test a post with a slower writer.
• [x] Test a long response.
• [x] Test a slove response reader.
• [ ] Test canceling an HTTP request:
  • as soon as the nsHttpChannel is open and a connection to the proxy does not exist already,
  • as soon as the nsHttpChannel is open and a connection to the proxy exists (only HTTP/2 proxy),
  • after the request is sent but before the response is received
  • while receiving a response.
    For the above tests check that the HTTP/2 connection to the proxy is not closed.
• [ ] Network connection breaks with different errors in different stages of a request and proxy setup.

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1755660 - Test redirected HTTPS requests through proxy r=#necko

The patch also changes test_server.js to await server shutdown when necessary.

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1755660 - Add proxy test for POST request with a slow writer r=#necko

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1755660 - Allow node proxies to handle POST requests r=#necko

We move from http.get to http.request to be able to pass the method to
the proxied request.
We alsoread the data from the stream and pipe it to the new request.

Depends on D155334

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd1684b91384
Test redirected HTTPS requests through proxy r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/8a9725c09d40
Allow node proxies to handle POST requests r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/06b90196355e
Add proxy test for POST request with a slow writer r=necko-reviewers,dragana

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cd1684b91384
https://hg.mozilla.org/mozilla-central/rev/8a9725c09d40
https://hg.mozilla.org/mozilla-central/rev/06b90196355e

Comment 10

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1755660 - Add tests for cancelling proxied channels r=#necko

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60fc8d3f8152
Add tests for cancelling proxied channels r=necko-reviewers,kershaw

Comment 12

[Noemi Erli[:noemi_erli]]

Backed out changeset 60fc8d3f8152 (Bug 1755660) for causing failures in test_proxy_cancel.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=FhLAKqCHSR2aGFLx-apk-w.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=60fc8d3f815251c9f8186e8c565b0665b84f898e

Log: https://treeherder.mozilla.org/logviewer?job_id=390546772&repo=autoland&lineNumber=4245

Backout: https://hg.mozilla.org/integration/autoland/rev/5910daede0a2de60e2c851b73122934e1e13fc16

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac2c4ef5bde1
Add tests for cancelling proxied channels r=necko-reviewers,kershaw

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ac2c4ef5bde1

Comment 15

[Dragana Damjanovic [:dragana]]

Hi Kershaw, my appolgies but may I ask you to land 2 patches from me? I will not have time to fix them. Thank you

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1a7df2f329c
Add tests for testing HTTP/2 to the origin server through a HTTP/2 proxy, r=necko-reviewers,valentin

Comment 17

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c1a7df2f329c

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f36319780923
Test progress notification with and without proxy r=necko-reviewers,valentin

Comment 19

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f36319780923

Comment 20

[Valentin Gosu [:valentin] (he/him)]

I assume we can close this now?

Comment 21

[Kershaw Chang [:kershaw]]

Yes, all tests are landed.