1755957 - [wpt-sync] Sync PR 32884 - [SPC] Add relying party ID input to SPC request

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32884 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32884
Details from upstream follow.

Nick Burris <[e-mail]> wrote:

[SPC] Add relying party ID input to SPC request

Implementation for the proposal[1] to add the credential's relying party
as input to a SecurePaymentConfirmationRequests.

This validates the request's RP ID against the stored SPC credential
data as part of the SPC request creation; in the future we also want to
forward this to webauthn to look up the credential by the relying party
ID as part of the authentication.

[1] https://github.com/w3c/secure-payment-confirmation/issues/164

Bug: 1298505
Change-Id: If8a305dfb608050107966b2bb6f365a3d2aeb18b

Reviewed-on: https://chromium-review.googlesource.com/3456482
WPT-Export-Revision: 4574da4bd432798dcdf12d292cee9bb5435ea247

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1162e290783a2d0e5cb77823d2e57b29f440b82d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 17 subtests

Status Summary

Firefox

OK : 1
FAIL: 17

Chrome

OK : 1
PASS: 16
FAIL: 1

Safari

OK : 1
PASS: 2
FAIL: 15

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/secure-payment-confirmation/constructor.https.html
Valid payment method data does not throw exceptions.: FAIL
The timeout field is optional.: FAIL

New Tests That Don't Pass

/secure-payment-confirmation/constructor.https.html
Valid payment method data does not throw exceptions.: FAIL (Chrome: PASS, Safari: PASS)
The timeout field is optional.: FAIL (Chrome: PASS, Safari: PASS)
Extra payment method not allowed afterward.: FAIL (Chrome: PASS, Safari: FAIL)
Extra payment method not allowed beforehand.: FAIL (Chrome: PASS, Safari: FAIL)
The credentialIds field is required.: FAIL (Chrome: PASS, Safari: FAIL)
The challenge field is required.: FAIL (Chrome: PASS, Safari: FAIL)
Empty credentialIds field throws exception.: FAIL (Chrome: PASS, Safari: FAIL)
Null challenge field throws exception.: FAIL (Chrome: PASS, Safari: FAIL)
Empty challenge field throws exception.: FAIL (Chrome: PASS, Safari: FAIL)
Timeout longer than 1 hour throws exception.: FAIL (Chrome: PASS, Safari: FAIL)
Large credentialIds value throws exception.: FAIL (Chrome: PASS, Safari: FAIL)
Large challenge value throws exception.: FAIL (Chrome: PASS, Safari: FAIL)
Instrument field is required.: FAIL (Chrome: PASS, Safari: FAIL)
Instrument display name is required.: FAIL (Chrome: PASS, Safari: FAIL)
Instrument icon is required.: FAIL (Chrome: PASS, Safari: FAIL)
Payee origin is required.: FAIL (Chrome: PASS, Safari: FAIL)
rpId is required.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/132107b8ad1c
[wpt PR 32884] - [SPC] Add relying party ID input to SPC request, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c2080e2a578f
[wpt PR 32884] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0695cddcb91b
[wpt PR 32884] - [SPC] Add relying party ID input to SPC request, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3db9bc621769
[wpt PR 32884] - Update wpt metadata, a=testonly

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0695cddcb91b
https://hg.mozilla.org/mozilla-central/rev/3db9bc621769